Re: [PATCH] mm/vmscan: fix error return in kswapd_run()

[Wanpeng Li <liwanp@linux.vnet.ibm.com>]

On Tue, Apr 02, 2013 at 07:09:45PM +0800, Xishi Qiu wrote:
>Fix the error return value in kswapd_run(). The bug was
>introduced by commit d5dc0ad928fb9e972001e552597fd0b794863f34
>"mm/vmscan: fix error number for failed kthread".
>

Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>

>Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
>---
> mm/vmscan.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/mm/vmscan.c b/mm/vmscan.c
>index 88c5fed..950636e 100644
>--- a/mm/vmscan.c
>+++ b/mm/vmscan.c
>@@ -3188,9 +3188,9 @@ int kswapd_run(int nid)
> 	if (IS_ERR(pgdat->kswapd)) {
> 		/* failure at boot is fatal */
> 		BUG_ON(system_state == SYSTEM_BOOTING);
>-		pgdat->kswapd = NULL;
> 		pr_err("Failed to start kswapd on node %d\n", nid);
> 		ret = PTR_ERR(pgdat->kswapd);
>+		pgdat->kswapd = NULL;
> 	}
> 	return ret;
> }
>-- 
>1.7.6.1
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org.  For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>