Re: [PATCH 3/3] powerpc/mpc512x: add platform code for MPC5125.

[Anatolij Gustschin <agust@denx.de>]

On Tue, 02 Apr 2013 11:49:22 +0200
Matteo Facchinetti <matteo.facchinetti@sirius-es.it> wrote:
...
> >          if (of_machine_is_compatible("fsl,mpc5121"))
> >                  return "fsl,mpc5121-psc";
> >
> >          if (of_machine_is_compatible("fsl,mpc5125"))
> >                  return "fsl,mpc5125-psc";
> >
> > but note that it will only work if we add these compatibles
> > to the compatible list of the root nodes in 5121 and 5125
> > device trees.
> 
> I agree with you.
> 
> But I don't like that:
> "fsl,mpc5121" is already present in <mpc5121.dtsi> and after its 
> inclusion in <mpc5121ads.dts> , compatible root node value is replaced 
> by "fsl,mpc5121ads".
> 
> Idea is automatically generate
>      compatible = "fsl,mpc5121", "fsl,mpc5121ads";
> using dtsi hierarchy.
> 
> Is there a way to extend compatible values instead of replace it?

Not that I am aware of. Note that the compatible list should
specify the compatibility from most specific to most general, so
the list in mpc5121ads.dts would look like

    compatible = "fsl,mpc5121ads", "fsl,mpc5121";

We can patch in-tree mpc512x dts files accordingly.

Thanks,

Anatolij

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0  Fax: +49-8142-66989-80 Email: office@denx.de