From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Glisse Subject: Re: [PATCH 01/10] drm/radeon: UVD doesn't needs VM on SI Date: Wed, 3 Apr 2013 10:42:31 -0400 Message-ID: <20130403144230.GB2010@gmail.com> References: <1364944719-5175-1-git-send-email-deathsimple@vodafone.de> <1364944719-5175-2-git-send-email-deathsimple@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-pb0-f48.google.com (mail-pb0-f48.google.com [209.85.160.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 538C4E5F83 for ; Wed, 3 Apr 2013 07:45:52 -0700 (PDT) Received: by mail-pb0-f48.google.com with SMTP id xb4so883427pbc.21 for ; Wed, 03 Apr 2013 07:45:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1364944719-5175-2-git-send-email-deathsimple@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, Apr 03, 2013 at 01:18:30AM +0200, Christian K=F6nig wrote: > Signed-off-by: Christian K=F6nig > --- > drivers/gpu/drm/radeon/radeon_cs.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > = > diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/= radeon_cs.c > index 70d3824..7d66e01 100644 > --- a/drivers/gpu/drm/radeon/radeon_cs.c > +++ b/drivers/gpu/drm/radeon/radeon_cs.c > @@ -241,15 +241,15 @@ int radeon_cs_parser_init(struct radeon_cs_parser *= p, void *data) > return -EINVAL; > } > = > + if (radeon_cs_get_ring(p, ring, priority)) > + return -EINVAL; > + > /* we only support VM on SI+ */ > - if ((p->rdev->family >=3D CHIP_TAHITI) && > - ((p->cs_flags & RADEON_CS_USE_VM) =3D=3D 0)) { > + if ((p->rdev->asic->ring[p->ring].cs_parse =3D=3D NULL) && > + ((p->cs_flags & RADEON_CS_USE_VM) =3D=3D 0)) { > DRM_ERROR("VM required on SI+!\n"); > return -EINVAL; What about updating the error message to something more appropriate like ring %d require virtual memory Cheers, Jerome > } > - > - if (radeon_cs_get_ring(p, ring, priority)) > - return -EINVAL; > } > = > /* deal with non-vm */ > -- = > 1.7.9.5 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel