Re: [PATCH] x86/xen: populate boot_params with EDD data

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Wed, Apr 03, 2013 at 01:49:16PM +0100, David Vrabel wrote:
> On 03/04/13 13:47, Jan Beulich wrote:
> >>>> On 03.04.13 at 13:10, David Vrabel <david.vrabel@citrix.com> wrote:
> >> +}
> >> +#else
> >> +static inline void __init load_edd(void)
> >> +{
> >> +}
> >> +#endif
> > 
> > And if you put the conditionals inside the curly braces, you can
> > avoid the else portion here altogether.
> 
> I thought the #if around the whole function was the standard pattern.
> Konrad, what's your opinion here?

That is the way to do it in the header files.

You are not doing this in a header, I would go with what
Jan suggested and just do the #ifdef CONFIG_EDD.. inside the function.

Also just for completness, lets call the function 'xen_load_edd'

> 
> David
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>