From: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Thierry Reding <thierry-TKn1d31QZ+o@public.gmane.org>
Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] usb: host: ehci-tegra: Fix oops in error cleanup
Date: Wed, 3 Apr 2013 11:40:50 -0700 [thread overview]
Message-ID: <20130403184050.GA9420@kroah.com> (raw)
In-Reply-To: <1364935250-26422-1-git-send-email-thierry-TKn1d31QZ+o@public.gmane.org>
On Tue, Apr 02, 2013 at 10:40:50PM +0200, Thierry Reding wrote:
> The cleanup path checks whether the transceiver was properly initialized
> using IS_ERR(). However it can also happen that the cleanup path is run
> before the transceiver was initialized (or the operating mode isn't set
> to TEGRA_USB_OTG) and is therefore NULL. Add a separate label for error
> unwinding and initialize the transceiver field to ERR_PTR(-ENODEV) when
> the operating mode isn't TEGRA_USB_OTG to allow for consistent checking.
>
> Signed-off-by: Thierry Reding <thierry-TKn1d31QZ+o@public.gmane.org>
> Acked-by: Venu Byravarasu <vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/usb/host/ehci-tegra.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
This patch fails to apply to my tree:
checking file drivers/usb/host/ehci-tegra.c
Hunk #2 succeeded at 765 with fuzz 1.
Hunk #3 succeeded at 774 with fuzz 2 (offset 1 line).
Hunk #4 FAILED at 796.
1 out of 4 hunks FAILED
Can you please fix it up and resend it, keeping the needed acks on it?
thanks,
greg k-h
prev parent reply other threads:[~2013-04-03 18:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 20:40 [PATCH] usb: host: ehci-tegra: Fix oops in error cleanup Thierry Reding
[not found] ` <1364935250-26422-1-git-send-email-thierry-TKn1d31QZ+o@public.gmane.org>
2013-04-02 21:11 ` Stephen Warren
2013-04-03 11:58 ` Venu Byravarasu
2013-04-03 18:40 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130403184050.GA9420@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry-TKn1d31QZ+o@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.