All of lore.kernel.org
 help / color / mirror / Atom feed
From: cdall@cs.columbia.edu (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: KVM: fix KVM_CAP_ARM_SET_DEVICE_ADDR reporting
Date: Wed, 3 Apr 2013 16:17:25 -0700	[thread overview]
Message-ID: <20130403231725.GI29227@gmail.com> (raw)
In-Reply-To: <1364982193-21867-1-git-send-email-marc.zyngier@arm.com>

On Wed, Apr 03, 2013 at 10:43:13AM +0100, Marc Zyngier wrote:
> Commit 3401d54696f9 (KVM: ARM: Introduce KVM_ARM_SET_DEVICE_ADDR
> ioctl) added support for the KVM_CAP_ARM_SET_DEVICE_ADDR capability,
> but failed to add a break in the relevant case statement, returning
> the number of CPUs instead.
> 
> Luckilly enough, the CONFIG_NR_CPUS=0 patch hasn't been merged yet
> (https://lkml.org/lkml/diff/2012/3/31/131/1), so the bug wasn't
> noticed.
> 
> Just give it a break!
> 
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
>  arch/arm/kvm/arm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c
> index 6cc076e..d568e83 100644
> --- a/arch/arm/kvm/arm.c
> +++ b/arch/arm/kvm/arm.c
> @@ -198,6 +198,7 @@ int kvm_dev_ioctl_check_extension(long ext)
>  		break;
>  	case KVM_CAP_ARM_SET_DEVICE_ADDR:
>  		r = 1;
> +		break;
>  	case KVM_CAP_NR_VCPUS:
>  		r = num_online_cpus();
>  		break;
> -- 
> 1.8.1.4
> 
> 
Whoops, nice catch. Thanks.

-Christoffer

      reply	other threads:[~2013-04-03 23:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03  9:43 [PATCH] ARM: KVM: fix KVM_CAP_ARM_SET_DEVICE_ADDR reporting Marc Zyngier
2013-04-03 23:17 ` Christoffer Dall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130403231725.GI29227@gmail.com \
    --to=cdall@cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.