All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] OMAP5: I2C: Add I2C4 and I2C5 bases
Date: Thu, 4 Apr 2013 11:03:18 -0500	[thread overview]
Message-ID: <20130404160318.GB9344@kahuna> (raw)
In-Reply-To: <515DA1AE.1010209@mm-sol.com>

On 18:52-20130404, Lubomir Popov wrote:
> V2 fixes line wrap issue of the patch itself.
> 
> Need to add these base addresses in order to use I2C4 and I2C5.
> 
> Signed-off-by: Lubomir Popov <lpopov@mm-sol.com>
> 
> ---
>  arch/arm/include/asm/arch-omap5/cpu.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/include/asm/arch-omap5/cpu.h b/arch/arm/include/asm/arch-omap5/cpu.h
> index 5e62013..044ab55 100644
> --- a/arch/arm/include/asm/arch-omap5/cpu.h
> +++ b/arch/arm/include/asm/arch-omap5/cpu.h
> @@ -142,6 +142,8 @@ struct watchdog {
>  #define I2C_BASE1		(OMAP54XX_L4_PER_BASE + 0x70000)
>  #define I2C_BASE2		(OMAP54XX_L4_PER_BASE + 0x72000)
>  #define I2C_BASE3		(OMAP54XX_L4_PER_BASE + 0x60000)
> +#define I2C_BASE4		(OMAP54XX_L4_PER_BASE + 0x7A000)
> +#define I2C_BASE5		(OMAP54XX_L4_PER_BASE + 0x7C000)
and used where.

Also could you repost the patches generated with
git format-patch -M -o someplace --cover-letter master..
so that the patches are numbered in the order that needs to be reviewed.

in general, if you introduce an macro, you need to use the macro in the
same patch. So, it seems to me that a few of your patches are supposed
to be squashed into a single one which enables i2c5 for omap5 as an
single patch.
>  
>  /* MUSB base */
>  #define MUSB_BASE		(OMAP54XX_L4_CORE_BASE + 0xAB000)
> -- 
> 1.7.9.5
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

-- 
Regards,
Nishanth Menon

      reply	other threads:[~2013-04-04 16:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-04 15:52 [U-Boot] [PATCH v2] OMAP5: I2C: Add I2C4 and I2C5 bases Lubomir Popov
2013-04-04 16:03 ` Nishanth Menon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130404160318.GB9344@kahuna \
    --to=nm@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.