From: Arnd Bergmann <arnd@arndb.de>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [char-misc-next] mei: add debugfs hooks
Date: Fri, 5 Apr 2013 14:15:02 +0200 [thread overview]
Message-ID: <201304051415.03122.arnd@arndb.de> (raw)
In-Reply-To: <1365119491-10467-1-git-send-email-tomas.winkler@intel.com>
On Friday 05 April 2013, Tomas Winkler wrote:
> debugfs exposes device state and list of me clients and their
> properties
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Just one small comment:
> +#define DEBUGFS_ADD_FILE(_mei, name, parent, mode) \
> + debugfs_create_file(#name, mode, parent, \
> + _mei, &mei_dbgfs_fops_##name)
This macro seems to obfuscate more than it helps. In general, string concatenation
in macros is problematic because it means you can no longer grep for where a
symbols is being used.
Arnd
next prev parent reply other threads:[~2013-04-05 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 23:51 [char-misc-next] mei: add debugfs hooks Tomas Winkler
2013-04-05 12:15 ` Arnd Bergmann [this message]
2013-04-05 12:40 ` Winkler, Tomas
-- strict thread matches above, loose matches on Subject: below --
2013-04-05 14:23 Tomas Winkler
2013-04-05 14:38 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304051415.03122.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.