All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
	tiwai@suse.de, broonie@opensource.wolfsonmicro.com,
	lgirdwood@gmail.com, vinod.koul@intel.com
Subject: Re: [PATCH 1/3] ALSA: compress_core: Update	calc_avail to use cumulative values
Date: Fri, 5 Apr 2013 16:18:45 +0100	[thread overview]
Message-ID: <20130405151845.GC20026@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <515EE4DC.6050005@linux.intel.com>

On Fri, Apr 05, 2013 at 09:51:08AM -0500, Pierre-Louis Bossart wrote:
> On 4/5/13 3:36 AM, Charles Keepax wrote:
>> If anything if we were looking to simplify I would be inclined to
>> keep the cumulative values?
>
> That is my proposal as well, app_ptr and hw_ptr are defined as offsets  
> but can't really be used to make the difference between buffer full and  
> buffer empty and won't work for your implementation. I believe in the  
> pcm case only cumulative values are used in the core.
> Vinod, please chime in...

Ah ok, I misunderstood. I will start having a look at what this
would take but wait for Vinod to give some feedback before I
upstream a new version.

Thanks,
Charles

  reply	other threads:[~2013-04-05 15:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03 12:13 [PATCH 1/3] ALSA: compress_core: Update calc_avail to use cumulative values Charles Keepax
2013-04-03 12:13 ` [PATCH 2/3] ALSA: compress_core: Split copy into seperate read and write callbacks Charles Keepax
2013-04-04 18:01   ` Pierre-Louis Bossart
2013-04-05  8:23     ` Charles Keepax
2013-04-09 11:15       ` Vinod Koul
2013-04-09 11:47         ` Mark Brown
2013-04-09 14:30           ` Takashi Iwai
2013-04-03 12:13 ` [PATCH 3/3] ASoC: soc-compress: " Charles Keepax
2013-04-09 11:15   ` Vinod Koul
2013-04-04 18:22 ` [PATCH 1/3] ALSA: compress_core: Update calc_avail to use cumulative values Pierre-Louis Bossart
2013-04-05  8:36   ` Charles Keepax
2013-04-05 14:51     ` Pierre-Louis Bossart
2013-04-05 15:18       ` Charles Keepax [this message]
2013-04-09 10:55         ` Vinod Koul
2013-04-10  3:59           ` Pierre-Louis Bossart
2013-04-10 10:01             ` Charles Keepax
2013-04-09 11:02 ` Vinod Koul
2013-04-10  9:57   ` Charles Keepax
2013-04-10 10:07   ` Charles Keepax
2013-04-10 13:03     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130405151845.GC20026@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.