From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Victor Julien <lists@inliniac.net>
Cc: Victor Julien <victor@inliniac.net>, netfilter-devel@vger.kernel.org
Subject: Re: [Ulogd2 PATCH 1/3] Remove configure check for libmnl, it is not used
Date: Fri, 5 Apr 2013 18:00:18 +0200 [thread overview]
Message-ID: <20130405160018.GA28792@localhost> (raw)
In-Reply-To: <515EF201.7030007@inliniac.net>
On Fri, Apr 05, 2013 at 05:47:13PM +0200, Victor Julien wrote:
> On 04/05/2013 05:34 PM, Pablo Neira Ayuso wrote:
> > On Fri, Apr 05, 2013 at 04:33:55PM +0200, Victor Julien wrote:
> >> If libmnl is missing configure fails. However, the lib is not used nor
> >> linked to.
> >>
> >> ---
> >> configure.ac | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/configure.ac b/configure.ac
> >> index c94704b..a439bee 100644
> >> --- a/configure.ac
> >> +++ b/configure.ac
> >> @@ -49,7 +49,6 @@ AC_SUBST([regular_CFLAGS])
> >>
> >> dnl Check for the right nfnetlink version
> >> PKG_CHECK_MODULES([LIBNFNETLINK], [libnfnetlink >= 1.0.1])
> >> -PKG_CHECK_MODULES([LIBMNL], [libmnl >= 1.0.3])
> >
> > input/sum/ulogd_inpflow_NFACCT.c
> >
> > needs this.
>
> Shouldn't it be a conditional check then? Only if nfacct is enabled?
That's fine with me.
next prev parent reply other threads:[~2013-04-05 16:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 14:33 [ulogd2] lower netfilter library requirements Victor Julien
2013-04-05 14:33 ` [Ulogd2 PATCH 1/3] Remove configure check for libmnl, it is not used Victor Julien
2013-04-05 15:34 ` Pablo Neira Ayuso
2013-04-05 15:47 ` Victor Julien
2013-04-05 16:00 ` Pablo Neira Ayuso [this message]
2013-04-05 14:33 ` [Ulogd2 PATCH 2/3] Lower libnfnetlink requirement to 1.0.0 Victor Julien
2013-04-05 15:39 ` Pablo Neira Ayuso
2013-04-05 16:08 ` Victor Julien
2013-04-05 16:23 ` Pablo Neira Ayuso
2013-04-05 14:33 ` [Ulogd2 PATCH 3/3] Lower libnetfilter_conntrack requirement to 0.9.1 Victor Julien
2013-04-05 15:37 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130405160018.GA28792@localhost \
--to=pablo@netfilter.org \
--cc=lists@inliniac.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=victor@inliniac.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.