From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Puff ." <puff65537@bansheeslibrary.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [RFC] drivers/staging/silicom/bp_proc.c removal
Date: Fri, 5 Apr 2013 10:37:54 -0700 [thread overview]
Message-ID: <20130405173754.GA18933@kroah.com> (raw)
In-Reply-To: <CAN4nR9cuvPgNK++N2=Mz3sifeuBfRtKdAEQ8m6MhcSvQVKn-Sg@mail.gmail.com>
On Fri, Apr 05, 2013 at 10:31:56AM -0700, Puff . wrote:
> No reason not to.
>
> ~~~~~~
> DanielC
>
> On Thu, Apr 4, 2013 at 12:12 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> It's all ifdefed out (on BYPASS_SUPPORT), severely bitrotten (try
> to remove the ifdef and watch what happens on attempt to build) and,
> AFAICS,
> it's a duplicate of the stuff in bp_mod.c.
>
> Is there any reason to keep it around? IOW, how about
> git rm drivers/staging/silicom/bp_proc.c
> git mv drivers/staging/silicom/bp{,ctl}_mod.c
> ed drivers/staging/silicom/Makefile <<EOF
> /bp_proc/d
> wq
> EOF
> and if anybody needs to see what used to be there, git history is enough...
Ok, I'll go do that later today, thanks.
greg k-h
next prev parent reply other threads:[~2013-04-05 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 19:12 [RFC] drivers/staging/silicom/bp_proc.c removal Al Viro
[not found] ` <CAN4nR9cuvPgNK++N2=Mz3sifeuBfRtKdAEQ8m6MhcSvQVKn-Sg@mail.gmail.com>
2013-04-05 17:37 ` Greg Kroah-Hartman [this message]
2013-04-05 17:48 ` Al Viro
2013-04-05 22:01 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130405173754.GA18933@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puff65537@bansheeslibrary.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.