From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Matthew Garrett <matthew.garrett@nebula.com>,
Zhang Rui <rui.zhang@intel.com>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Joe Perches <joe@perches.com>,
Randy Dunlap <rdunlap@infradead.org>,
Paul Bolle <pebolle@tiscali.nl>
Subject: Re: [PATCH v2] RAPL (Running Average Power Limit) driver
Date: Fri, 5 Apr 2013 14:06:05 -0700 [thread overview]
Message-ID: <20130405210605.GA18505@kroah.com> (raw)
In-Reply-To: <1365195724-8945-1-git-send-email-jacob.jun.pan@linux.intel.com>
On Fri, Apr 05, 2013 at 02:02:03PM -0700, Jacob Pan wrote:
> Changes since V2:
> - use 'struct device' instead of raw kobject to represent
> RAPL domains
> - changed eventfd control interface to use event string
> instead of passing file descriptors that cannot be
> authenticated in sysfs directory
> - clean ups based on v1 reviews
> - use kcalloc for arrays
> - drop dependencies on X86
> - misc cleanups
Please no, split this up into at least 2 patches, the first being the
"standard" thermal driver, and the rest for the "custom" extensions you
are proposing.
That way the first can get accepted easily, and into 3.10 (hopefully),
so people can use it and not stall everything as we continue to iterate
over the "custom" things.
As is, this driver isn't acceptable, sorry.
greg k-h
prev parent reply other threads:[~2013-04-05 21:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 21:02 [PATCH v2] RAPL (Running Average Power Limit) driver Jacob Pan
2013-04-05 21:02 ` [PATCH v2] Introduce Intel RAPL cooling device driver Jacob Pan
2013-04-05 21:06 ` Greg Kroah-Hartman
2013-04-05 21:26 ` Joe Perches
2013-04-05 21:35 ` Greg Kroah-Hartman
2013-04-12 15:32 ` Jacob Pan
2013-04-12 15:39 ` Greg Kroah-Hartman
2013-04-05 21:57 ` Jacob Pan
2013-04-05 21:06 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130405210605.GA18505@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arjan@linux.intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=pebolle@tiscali.nl \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.