All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: Chase Maupin <Chase.Maupin@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [PATCH] tisdk-image: add support for DTB files
Date: Fri, 05 Apr 2013 19:57:01 -0400	[thread overview]
Message-ID: <20130405235701.GH31233@denix.org> (raw)
In-Reply-To: <1365007710-12866-1-git-send-email-Chase.Maupin@ti.com>

On Wed, Apr 03, 2013 at 11:48:30AM -0500, Chase Maupin wrote:
> * If DTB files exist add support for copying those files into
>   the SDK prebuilt-images directory.
> * The files to be copied can be controlled using the DTB_FILTER
>   variable.
> 
> Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> ---
>  meta-arago-distro/classes/tisdk-image.bbclass |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/meta-arago-distro/classes/tisdk-image.bbclass b/meta-arago-distro/classes/tisdk-image.bbclass
> index a1ce1ad..4e3ed52 100644
> --- a/meta-arago-distro/classes/tisdk-image.bbclass
> +++ b/meta-arago-distro/classes/tisdk-image.bbclass
> @@ -528,6 +528,16 @@ do_sdk_image () {
>          return 1
>      fi

I was thinking of adding DTB_FILTER ?= "unknown" here, but then realized it 
would just waste few cycles trying to find something in the deploy directory, 
which we can avoid completely by testing if it set or not...


> +    # Copy the DTB files if they exist.
> +    # NOTE: For simplicity remove the uImage- prefix on the dtb files.  Get just the symlink
> +    #       files for a cleaner name.  Use the DTB_FILTER variable to allow finding the
> +    #       dtb files for only that MACHINE type

Wrap the below for loop in "if [ -z "${DTB_FILTER}" ]; then" here?


> +    for f in `find ${DEPLOY_DIR_IMAGE} -type l -name "*${DTB_FILTER}*.dtb"`
> +    do
> +        dtb_file=`basename $f | sed s/uImage-//`
> +        cp $f ${prebuilt_dir}/${dtb_file}
> +    done
> +
>      if [ "${SECONDARY_BOOTLOADER_NAME}" != "" ]
>      then
>          # Copy the secondary bootloader image if it exists
> -- 
> 1.7.0.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> 


  reply	other threads:[~2013-04-05 23:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03 16:48 [PATCH] tisdk-image: add support for DTB files Chase Maupin
2013-04-05 23:57 ` Denys Dmytriyenko [this message]
2013-04-06  1:37   ` Maupin, Chase
2013-04-10 21:48     ` Denys Dmytriyenko
2013-04-10 21:58       ` Maupin, Chase
2013-04-10 22:02         ` Denys Dmytriyenko
2013-04-11 13:28           ` Maupin, Chase

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130405235701.GH31233@denix.org \
    --to=denys@ti.com \
    --cc=Chase.Maupin@ti.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.