From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/5] drivers: memory: Introduce Marvell EBU Device Bus driver
Date: Sat, 6 Apr 2013 15:05:33 +0200 [thread overview]
Message-ID: <201304061505.33946.arnd@arndb.de> (raw)
In-Reply-To: <1365246930-13315-2-git-send-email-ezequiel.garcia@free-electrons.com>
On Saturday 06 April 2013, Ezequiel Garcia wrote:
> + - devbus,dev-width: 0x0 = 8-bit
> + 0x1 = 16-bit
> + 0x2 = 32-bit
> + 0x3 = Reserved
I think by convention this should be called "bus-width" and allow the
values <8>, <16> and <32>, each referrring to the width in bits.
> +/* Perhaps it makes sense to unify both compatible strins? */
> +static const struct of_device_id mvebu_devbus_of_match[] = {
> + { .compatible = "marvell,armada370-devbus" },
> + { .compatible = "marvell,armadaxp-devbus" },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, mvebu_devbus_of_match);
Yes, if the hardware behaves identically and all the differences are
described in the other properties, just name it after the first soc
that had this devbus.
Arnd
next prev parent reply other threads:[~2013-04-06 13:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 11:15 [PATCH v3 0/5] Device Bus support for Marvell EBU SoC Ezequiel Garcia
2013-04-06 11:15 ` [PATCH v3 1/5] drivers: memory: Introduce Marvell EBU Device Bus driver Ezequiel Garcia
2013-04-06 13:05 ` Arnd Bergmann [this message]
2013-04-06 13:34 ` Arnd Bergmann
2013-04-06 14:50 ` Ezequiel Garcia
2013-04-06 11:15 ` [PATCH v3 2/5] ARM: mvebu: Add Device Bus support for Armada 370/XP SoC Ezequiel Garcia
2013-04-06 11:15 ` [PATCH v3 3/5] ARM: mvebu: Add support for NOR flash device on Armada XP-GP board Ezequiel Garcia
2013-04-06 11:15 ` [PATCH v3 4/5] ARM: mvebu: Add support for NOR flash device on Openblocks AX3 board Ezequiel Garcia
2013-04-06 11:15 ` [PATCH v3 5/5] ARM: mvebu: Add Device Bus and CFI flash memory support to defconfig Ezequiel Garcia
2013-04-06 13:09 ` [PATCH v3 0/5] Device Bus support for Marvell EBU SoC Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304061505.33946.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.