All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Hans-Peter Jansen <hpj@urpla.net>
Cc: Adam Sampson <ats@offog.org>,
	linux-media@vger.kernel.org, jdonog01@eircom.net,
	bugzilla-kernel@tcnnet.com
Subject: Re: Hauppauge Nova-S-Plus DVB-S works for one channel, but cannot tune in others
Date: Sat, 6 Apr 2013 16:26:32 -0300	[thread overview]
Message-ID: <20130406162632.7d9228b7@redhat.com> (raw)
In-Reply-To: <1580900.OVB5S0HrEf@xrated>

Em Sat, 06 Apr 2013 19:26:23 +0200
Hans-Peter Jansen <hpj@urpla.net> escreveu:

> On Samstag, 6. April 2013 10:37:52 you wrote:
> > Em Sat, 06 Apr 2013 12:20:41 +0200
> > 
> > Hans-Peter Jansen <hpj@urpla.net> escreveu:
> > > Dear Mauro,
> > > 
> > > first of all, thank you for providing a proper fix that quickly.
> > > 
> > > On Freitag, 5. April 2013 13:18:54 Mauro Carvalho Chehab wrote:
> > > > Em Fri, 05 Apr 2013 13:25:01 +0100
> > > > 
> > > > Adam Sampson <ats@offog.org> escreveu:
> > > > > Hans-Peter Jansen <hpj@urpla.net> writes:
> > > > > > In one of my systems, I've used a
> > > > > > Hauppauge Nova-S-Plus DVB-S card successfully, but after a system
> > > > > > upgrade to openSUSE 12.2, it cannot tune in all but one channel.
> > > > > 
> > > > > [...]
> > > > > 
> > > > > > initial transponder 12551500 V 22000000 5
> > > > > > 
> > > > > >>>> tune to: 12551:v:0:22000
> > > > > > 
> > > > > > DVB-S IF freq is 1951500
> > > > > > WARNING: >>> tuning failed!!!
> > > > > 
> > > > > I suspect you might be running into this problem:
> > > > >   https://bugzilla.kernel.org/show_bug.cgi?id=9476
> > > > > 
> > > > > The bug title is misleading -- the problem is actually that the card
> > > > > doesn't get configured properly to send the 22kHz tone for high-band
> > > > > transponders, like the one in your error above.
> > > > > 
> > > > > Applying this patch makes my Nova-S-Plus work with recent kernels:
> > > > >   https://bugzilla.kernel.org/attachment.cgi?id=21905&action=edit
> > > > 
> > > > Applying that patch would break support for all other devices with
> > > > isl6421.
> > > > 
> > > > Could you please test the enclosed patch? It allows the bridge
> > > > driver to tell if the set_tone should be overrided by isl6421 or
> > > > not. The code only changes it for Hauppauge model 92001.
> > > 
> > > Unfortunately, it appears to be more problematic. While the fix allows to
> > > scan the channel list, it is not complete (in another setup at the same
> > > dish (via multiswitch), vdrs channel list has about 1600 channels, while
> > > scan does collect 1138 only.
> > > 
> > > More importantly, a single channel (arte) is received with 0 BER and a S/N
> > > ratio of 99%, while all other channels produce more BER, eg. "Das Erste"
> > > with about 320 BER (SNR 99%, a few artifacts/distortions occasionally),
> > > "ZDF" about 6400 BER, (SNR drops down to 75%, constant distortions, and
> > > many channels doesn't produce anything beyond distortions with a video
> > > stream below 0.3 MBit/s and about 160000 BER. (measured using vdr femon
> > > plugin v. 1.6.7)
> > > 
> > > So, still no cigar, sorry.
> > > 
> > > I've tested both patches, just to be sure, with the same result. I had to
> > > relocate and refresh yours in order to apply it to 3.4, since the paths
> > > changed, result attached.
> > > 
> > > > If it works, please answer this email with a:
> > > > 	Tested-by: your name <your@email>
> > > > 
> > > > For me to add it when merging the patch upstream.
> > > > 
> > > > Regards,
> > > > Mauro.
> > > 
> > > It looks like the idea is sound, but the logic is still missing something
> > > that prevents it from tuning most channels properly.
> > 
> > Well, what it is expected from this patch is to be able of seeing
> > channels with H and V polarization. Nothing more, nothing less.
> 
> Okay. Yes, I do.
> 
> > From what I understood, you're now seeing more than just one channel,
> > so, it is likely part of the fix, right?
> 
> Yes.

Ok, I'll likely be merging it by Monday.
> 
> > If are there any other issues, then it it would require other fixes,
> > likely at cx24123 frontend. My guess is that it could be due to some
> > precision loss maybe at cx24123_set_symbolrate(). It helps if you could
> > check if the channels that are more problematic have a higher or a
> > lower bit rate. It probably makes sense to change the code there to
> > use u64 and asm/div64.h, in order to allow the calculus to have more
> > precision. I'll try to write such patch.
> 
> ..that I'm testing right now. Build is on the way.
> 
> You wrote and published the fix in less then 8 minutes. Wow, unbelievable.

Well, the patch is really trivial. If it works or not, only the tests can
tell ;) I have one Nova-S model here, but unfortunately I don't have a
satellite dish anymore, so I can't test.

> Since I use a rpm build of an otherwise unchanged distribution kernel, the 
> build will take slightly longer, unfortunately..

Yeah, rebuilding the entire kernel with rpm takes some time ;)

> > With regards to this fix, could you please confirm that you can
> > now get channels with both polarizations?
> 
> Yes, confirmed.
> 
> Tested-by: Hans-Peter Jansen <hpj@urpla.net>
> 
> Thanks Mauro for the great support.

Thanks for testing it!

Regards,
Mauro

  reply	other threads:[~2013-04-06 19:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-05 11:46 Hauppauge Nova-S-Plus DVB-S works for one channel, but cannot tune in others Hans-Peter Jansen
2013-04-05 12:25 ` Adam Sampson
2013-04-05 16:18   ` Mauro Carvalho Chehab
2013-04-06 10:20     ` Hans-Peter Jansen
2013-04-06 13:37       ` Mauro Carvalho Chehab
2013-04-06 17:26         ` Hans-Peter Jansen
2013-04-06 19:26           ` Mauro Carvalho Chehab [this message]
2013-04-06 20:20             ` Hans-Peter Jansen
2013-04-07 17:03               ` Mauro Carvalho Chehab
2013-04-07 19:10                 ` Hans-Peter Jansen
2013-04-08  2:39                   ` Mauro Carvalho Chehab
2013-04-06 13:45       ` [PATCH] cx24123: improve precision when calculating symbol rate ratio Mauro Carvalho Chehab
2013-04-06 12:59     ` Hauppauge Nova-S-Plus DVB-S works for one channel, but cannot tune in others Adam Sampson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130406162632.7d9228b7@redhat.com \
    --to=mchehab@redhat.com \
    --cc=ats@offog.org \
    --cc=bugzilla-kernel@tcnnet.com \
    --cc=hpj@urpla.net \
    --cc=jdonog01@eircom.net \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.