From: Robert Richter <rric@kernel.org>
To: Borislav Petkov <bp@alien8.de>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Borislav Petkov <bp@suse.de>
Subject: Re: [RFC PATCH 2/3] perf: Add persistent event facilities
Date: Sat, 6 Apr 2013 18:29:07 +0200 [thread overview]
Message-ID: <20130406162907.GG11652@rric.localhost> (raw)
In-Reply-To: <20130403172712.GA4716@pd.tnic>
On 03.04.13 19:27:12, Borislav Petkov wrote:
> > > + list_for_each_entry(desc, &per_cpu(pers_events, cpu), plist) {
> > > +
> > > + if (desc->attr->config != attr->config)
> > > + continue;
> >
> > Umm, the attr->config is not sufficient as a selector since it must be
> > unique which is not granted (of course it works for one event only).
>
> Right, so the tracepoints are enumerated by tracing code at boot
> time. But not the hw events, for example. How can we select events
> unambiguously?
As we discussed personally, in a first version we should allow only
the tracepoint pmu to be used for persistent events. The config value
is then unique and the above works.
-Robert
next prev parent reply other threads:[~2013-04-06 16:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 13:06 [RFC PATCH 0/3] Perf persistent events Borislav Petkov
2013-03-15 13:06 ` [RFC PATCH 1/3] perf: Add " Borislav Petkov
2013-04-06 15:53 ` Robert Richter
2013-04-07 10:31 ` Borislav Petkov
2013-03-15 13:06 ` [RFC PATCH 2/3] perf: Add persistent event facilities Borislav Petkov
2013-03-18 9:13 ` Namhyung Kim
2013-03-18 12:11 ` Borislav Petkov
2013-03-28 18:15 ` Robert Richter
2013-04-03 17:27 ` Borislav Petkov
2013-04-06 16:29 ` Robert Richter [this message]
2013-03-15 13:06 ` [RFC PATCH 3/3] MCE: Enable persistent event Borislav Petkov
2013-03-18 8:38 ` [RFC PATCH 0/3] Perf persistent events Namhyung Kim
2013-03-18 8:46 ` Ingo Molnar
2013-03-28 15:52 ` Robert Richter
2013-03-29 14:25 ` Borislav Petkov
2013-03-18 8:40 ` Ingo Molnar
2013-03-18 15:16 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130406162907.GG11652@rric.localhost \
--to=rric@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.