From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called Date: Sat, 6 Apr 2013 22:50:33 +0100 Message-ID: <20130406215033.GM4068@ZenIV.linux.org.uk> References: <515FF344.8040705@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux FS Devel , Chris Mason , Steve French , Theodore Ts'o , Andreas Dilger , Miklos Szeredi , Anton Altaparmakov , Mark Fasheh , Joel Becker , Ben Myers , Alex Elder , xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org, Matthew Wilcox , Mike Snitzer , Alasdair G Kergon , linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, fuse-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-ntfs-dev-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, ocfs2-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Jan Kara To: Marco Stornelli Return-path: Content-Disposition: inline In-Reply-To: <515FF344.8040705-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote: > In every place where sb_start_write was called now we must manage > the error code and return -EINTR. Now go and look for callers of mnt_want_write() ;-/ The really painful one is in do_last(), but kern_path_create() is not much better; mq_open() would be bad too, had it not been about something you are not going to freeze anyway... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:56504 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161113Ab3DFVun (ORCPT ); Sat, 6 Apr 2013 17:50:43 -0400 Date: Sat, 6 Apr 2013 22:50:33 +0100 From: Al Viro To: Marco Stornelli Cc: Linux FS Devel , Chris Mason , Steve French , "Theodore Ts'o" , Andreas Dilger , Miklos Szeredi , Anton Altaparmakov , Mark Fasheh , Joel Becker , Ben Myers , Alex Elder , xfs@oss.sgi.com, Matthew Wilcox , Mike Snitzer , Alasdair G Kergon , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-ext4@vger.kernel.org, fuse-devel@lists.sourceforge.net, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, Jan Kara Subject: Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called Message-ID: <20130406215033.GM4068@ZenIV.linux.org.uk> References: <515FF344.8040705@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <515FF344.8040705@gmail.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote: > In every place where sb_start_write was called now we must manage > the error code and return -EINTR. Now go and look for callers of mnt_want_write() ;-/ The really painful one is in do_last(), but kern_path_create() is not much better; mq_open() would be bad too, had it not been about something you are not going to freeze anyway... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 63E5F7F55 for ; Sat, 6 Apr 2013 16:50:59 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id 4570D304039 for ; Sat, 6 Apr 2013 14:50:55 -0700 (PDT) Date: Sat, 6 Apr 2013 22:50:33 +0100 From: Al Viro Subject: Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called Message-ID: <20130406215033.GM4068@ZenIV.linux.org.uk> References: <515FF344.8040705@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <515FF344.8040705@gmail.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Marco Stornelli Cc: Chris Mason , Jan Kara , Mike Snitzer , linux-mm@kvack.org, Andreas Dilger , Alasdair G Kergon , linux-cifs@vger.kernel.org, Miklos Szeredi , linux-ext4@vger.kernel.org, Matthew Wilcox , fuse-devel@lists.sourceforge.net, Mark Fasheh , xfs@oss.sgi.com, Ben Myers , Joel Becker , Anton Altaparmakov , Alex Elder , Theodore Ts'o , linux-ntfs-dev@lists.sourceforge.net, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, Steve French , ocfs2-devel@oss.oracle.com, Linux FS Devel , linux-btrfs@vger.kernel.org On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote: > In every place where sb_start_write was called now we must manage > the error code and return -EINTR. Now go and look for callers of mnt_want_write() ;-/ The really painful one is in do_last(), but kern_path_create() is not much better; mq_open() would be bad too, had it not been about something you are not going to freeze anyway... _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Date: Sat, 06 Apr 2013 21:51:16 -0000 Subject: [Ocfs2-devel] [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called In-Reply-To: <515FF344.8040705@gmail.com> References: <515FF344.8040705@gmail.com> Message-ID: <20130406215033.GM4068@ZenIV.linux.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Marco Stornelli Cc: Linux FS Devel , Chris Mason , Steve French , Theodore Ts'o , Andreas Dilger , Miklos Szeredi , Anton Altaparmakov , Mark Fasheh , Joel Becker , Ben Myers , Alex Elder , xfs@oss.sgi.com, Matthew Wilcox , Mike Snitzer , Alasdair G Kergon , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-ext4@vger.kernel.org, fuse-devel@lists.sourceforge.net, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, Jan Kara On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote: > In every place where sb_start_write was called now we must manage > the error code and return -EINTR. Now go and look for callers of mnt_want_write() ;-/ The really painful one is in do_last(), but kern_path_create() is not much better; mq_open() would be bad too, had it not been about something you are not going to freeze anyway... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx200.postini.com [74.125.245.200]) by kanga.kvack.org (Postfix) with SMTP id 4B3906B0005 for ; Sat, 6 Apr 2013 17:51:09 -0400 (EDT) Date: Sat, 6 Apr 2013 22:50:33 +0100 From: Al Viro Subject: Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called Message-ID: <20130406215033.GM4068@ZenIV.linux.org.uk> References: <515FF344.8040705@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <515FF344.8040705@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Marco Stornelli Cc: Linux FS Devel , Chris Mason , Steve French , Theodore Ts'o , Andreas Dilger , Miklos Szeredi , Anton Altaparmakov , Mark Fasheh , Joel Becker , Ben Myers , Alex Elder , xfs@oss.sgi.com, Matthew Wilcox , Mike Snitzer , Alasdair G Kergon , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-ext4@vger.kernel.org, fuse-devel@lists.sourceforge.net, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, Jan Kara On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote: > In every place where sb_start_write was called now we must manage > the error code and return -EINTR. Now go and look for callers of mnt_want_write() ;-/ The really painful one is in do_last(), but kern_path_create() is not much better; mq_open() would be bad too, had it not been about something you are not going to freeze anyway... -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org