From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UOjBu-0001HN-0b for mharc-grub-devel@gnu.org; Sun, 07 Apr 2013 02:35:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOjBq-0001Gi-QQ for grub-devel@gnu.org; Sun, 07 Apr 2013 02:35:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UOjBn-0004cb-2v for grub-devel@gnu.org; Sun, 07 Apr 2013 02:34:58 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:45209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOjBm-0004cH-Ra for grub-devel@gnu.org; Sun, 07 Apr 2013 02:34:55 -0400 Received: by mail-lb0-f172.google.com with SMTP id u10so4834635lbi.3 for ; Sat, 06 Apr 2013 23:34:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:subject:message-id:in-reply-to:references :x-mailer:mime-version:content-type; bh=oTX/+ZV91SQ1rhPUgxz4c6+vKga/Ju6RRUldX80Uqdk=; b=xpW1DV4ZIGWDNAckTVxyRVrLRuMacqXSbrBDswCQGQlh4U8oU1ibtwCtEPWu8Br9tx de9GAcUd1WOiNxmmbeTkTJpeRxUoYE4IuCBcbbQ52wxk5wNJjVRz6bdlR96T9d+FxR1E t8FrrFwyvK9txiFAYaUjdys+bsT2vXurMYj/7EqWGvAA12hN7fA6NuT8Nr+DlZmG0UMY vUNODxqOMS4BL289JehyrlRs0PxXoCZzgxjRwvHkhHwslbsNsVnob2LKAtDrk8mxxlPp 3B/2nDI4Kgm/XM1fI+F3Gu3Goy06OFtdTzIyuJu+/TVwvIn5ydr34MnCcb33YuJfV32r x1jg== X-Received: by 10.112.150.101 with SMTP id uh5mr9479325lbb.92.1365316493715; Sat, 06 Apr 2013 23:34:53 -0700 (PDT) Received: from opensuse.site ([94.29.72.160]) by mx.google.com with ESMTPS id fz10sm8418842lbb.12.2013.04.06.23.34.52 (version=SSLv3 cipher=RC4-SHA bits=128/128); Sat, 06 Apr 2013 23:34:53 -0700 (PDT) Date: Sun, 7 Apr 2013 10:34:52 +0400 From: Andrey Borzenkov To: grub-devel@gnu.org Subject: Re: [PATCH] 30_os-prober: add $onstr ot top level Linux entries too Message-ID: <20130407103452.5c22fe2a@opensuse.site> In-Reply-To: <516079EC.50609@gmail.com> References: <1365147045-4958-1-git-send-email-arvidjaar@gmail.com> <516079EC.50609@gmail.com> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.14; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/L9DKVIXjn_wqN=NuN7exnjo"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.217.172 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Apr 2013 06:35:01 -0000 --Sig_/L9DKVIXjn_wqN=NuN7exnjo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Sat, 06 Apr 2013 21:39:24 +0200 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > On 05.04.2013 09:30, Andrey Borzenkov wrote: >=20 > > This fixes two issues > >=20 > > 1. It visually distinguishes between multiple installations of the > > same OS version. Currently all of them get identical titles. > >=20 >=20 > I don't know how "speaking" the device names are in practice. They are > not stable and what is sda1 under one install can be sdb1 under another > one. Perhaps we should use some other kind of identifier for this. >=20 Well, a) those names are from the perspective of a single installation only. In this respect it does not matter how another install calls it. b) this is already used for some of menu entries. So it is just to establish consistency. If something better is invented, I am fine with it, but current situation is inconsistent. > > 2. linux prober is using "(on /dev/xxx)" as indication that entry has > > to be skipped. Top level entries should be skipped too. >=20 > This is improper. This string can be translated and e.g. '(=D0=BD=D0=B0 /= dev/xxx)' > or '(auf /dev/xxx)' won't match '(on /dev/xxx)'. "$menuentry_id_option > 'osprober-" should be used instead (and (on ...) be kept in or-way for > backward compatibility). >=20 Ah. Did not occur to me, thank you for idea!=20 --Sig_/L9DKVIXjn_wqN=NuN7exnjo Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAlFhE4wACgkQR6LMutpd94zqbwCgozDQQ+S6z3lQg3FhYlcZNPF1 MkAAnAvTYaR2Nb1YgmWBCisrRAEQlDJR =ZhPC -----END PGP SIGNATURE----- --Sig_/L9DKVIXjn_wqN=NuN7exnjo--