From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] PM/reboot: call syscore_shutdown() after disable_nonboot_cpus() Date: Sun, 7 Apr 2013 08:29:32 -0700 Message-ID: <20130407152932.GA18032@kroah.com> References: <1365300854-3133-1-git-send-email-chenhc@lemote.com> <3513307.9cks2gqsZt@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-da0-f53.google.com ([209.85.210.53]:44772 "EHLO mail-da0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933938Ab3DGP3g (ORCPT ); Sun, 7 Apr 2013 11:29:36 -0400 Received: by mail-da0-f53.google.com with SMTP id n34so2264482dal.12 for ; Sun, 07 Apr 2013 08:29:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <3513307.9cks2gqsZt@vostro.rjw.lan> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: "Rafael J. Wysocki" Cc: Huacai Chen , Andrew Morton , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Fuxin Zhang , stable@vger.kernel.org On Sun, Apr 07, 2013 at 10:46:00AM +0200, Rafael J. Wysocki wrote: > On Sunday, April 07, 2013 10:14:14 AM Huacai Chen wrote: > > As commit 40dc166c (PM / Core: Introduce struct syscore_ops for core > > subsystems PM) say, syscore_ops operations should be carried with one > > CPU on-line and interrupts disabled. However, after commit f96972f2d > > (kernel/sys.c: call disable_nonboot_cpus() in kernel_restart()), > > syscore_shutdown() is called before disable_nonboot_cpus(), so break > > the rules. We have a MIPS machine with a 8259A PIC, and there is an > > external timer (HPET) linked at 8259A. Since 8259A has been shutdown > > too early (by syscore_shutdown()), disable_nonboot_cpus() runs without > > timer interrupt, so it hangs and reboot fails. This patch call > > syscore_shutdown() a little later (after disable_nonboot_cpus()) to > > avoid reboot failure, this is the same way as poweroff does. > > > > BTW, add disable_nonboot_cpus() in kernel_halt() for consistency. > > > > Signed-off-by: Huacai Chen > > Cc: > > While I agree with the changes, I'm not sure if I'm the right maintainer, > as this isn't really PM code. > > Andrew, should I take this? Andrew is on vacation for a few weeks, so you might need to take this through your tree. greg k-h