From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Jiang Liu <liuj97@gmail.com>
Cc: Jiang Liu <jiang.liu@huawei.com>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] AVR32: fix building warnings caused by redifinitions of HZ
Date: Mon, 8 Apr 2013 08:55:42 +0200 [thread overview]
Message-ID: <20130408065542.GA28741@samfundet.no> (raw)
In-Reply-To: <516190CD.8040800@gmail.com>
Around Sun 07 Apr 2013 23:29:17 +0800 or thereabout, Jiang Liu wrote:
> On 04/07/2013 03:55 PM, Hans-Christian Egtvedt wrote:
>> Around Sun 07 Apr 2013 00:43:36 +0800 or thereabout, Jiang Liu wrote:
>>> Fix building warnings caused by redifinitions of HZ:
<snipp warning>
>> Thanks for fixing.
>>
>>> Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
>>> Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
>>> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
>>> Cc: linux-kernel@vger.kernel.org
>>
>> Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
>>
>>> ---
>>> arch/avr32/include/uapi/asm/param.h | 6 +++++-
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/avr32/include/uapi/asm/param.h b/arch/avr32/include/uapi/asm/param.h
>>> index d28aa5e..abda103 100644
>>> --- a/arch/avr32/include/uapi/asm/param.h
>>> +++ b/arch/avr32/include/uapi/asm/param.h
>>> @@ -2,7 +2,11 @@
>>> #define _UAPI__ASM_AVR32_PARAM_H
>>>
>>>
>>> -#ifndef HZ
>>> +#ifndef __KERNEL__
>>> + /*
>>> + * Technically, this is wrong, but some old apps still refer to it.
>>> + * The proper way to get the HZ value is via sysconf(_SC_CLK_TCK).
>>> + */
>>
>> With this comment, are there AVR32 drivers/users that should be fixed? Or is
>> it parts of the tree in general?
> Hi Hans,
> It's copied from arch/ia64/include/uapi/asm/param.h, I feel it should be
> the same for AVR32 too.
Most likely yes, the original param.h header file was added by David Howells
from RedHat, and has never been touched since.
Again, thanks for fixing.
--
mvh
Hans-Christian Egtvedt
prev parent reply other threads:[~2013-04-08 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 16:43 [PATCH] AVR32: fix building warnings caused by redifinitions of HZ Jiang Liu
2013-04-07 7:55 ` Hans-Christian Egtvedt
2013-04-07 15:29 ` Jiang Liu
2013-04-08 6:55 ` Hans-Christian Egtvedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408065542.GA28741@samfundet.no \
--to=egtvedt@samfundet.no \
--cc=hskinnemoen@gmail.com \
--cc=jiang.liu@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuj97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.