Re: [PATCH 4/4] regulator: ab8500-ext: Remove get_voltage to avoid duplicate implementation

[Lee Jones <lee.jones@linaro.org>]

On Sun, 07 Apr 2013, Axel Lin wrote:

> The implementation of ab8500_ext_fixed_get_voltage is identical to
> ab8500_ext_list_voltage. We can avoid the duplicate implementation by just
> remove get_voltage. For fixed regulator, regulator core will call
> list_voltage(rdev, 0) to get voltage if both get_voltage get_voltage_sel are
> not implemented.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Nice simplification:

Acked-by: Lee Jones <lee.jones@linaro.org>

> ---
>  drivers/regulator/ab8500-ext.c |   16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/drivers/regulator/ab8500-ext.c b/drivers/regulator/ab8500-ext.c
> index c7896af..9aee21c 100644
> --- a/drivers/regulator/ab8500-ext.c
> +++ b/drivers/regulator/ab8500-ext.c
> @@ -237,21 +237,6 @@ static unsigned int ab8500_ext_regulator_get_mode(struct regulator_dev *rdev)
>  	return ret;
>  }
>  
> -static int ab8500_ext_fixed_get_voltage(struct regulator_dev *rdev)
> -{
> -	struct regulation_constraints *regu_constraints = rdev->constraints;
> -
> -	if (regu_constraints == NULL) {
> -		dev_err(rdev_get_dev(rdev), "regulator constraints null pointer\n");
> -		return -EINVAL;
> -	}
> -	if (regu_constraints->min_uV && regu_constraints->max_uV) {
> -		if (regu_constraints->min_uV == regu_constraints->max_uV)
> -			return regu_constraints->min_uV;
> -	}
> -	return -EINVAL;
> -}
> -
>  static int ab8500_ext_list_voltage(struct regulator_dev *rdev,
>  				   unsigned selector)
>  {
> @@ -275,7 +260,6 @@ static struct regulator_ops ab8500_ext_regulator_ops = {
>  	.is_enabled		= ab8500_ext_regulator_is_enabled,
>  	.set_mode		= ab8500_ext_regulator_set_mode,
>  	.get_mode		= ab8500_ext_regulator_get_mode,
> -	.get_voltage		= ab8500_ext_fixed_get_voltage,
>  	.list_voltage		= ab8500_ext_list_voltage,
>  };
>  

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog