From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 3/3] xl: 'xl info' print outstanding claims if enabled (claim_mode=1 in xl.conf) Date: Mon, 8 Apr 2013 14:16:16 -0400 Message-ID: <20130408181616.GD24288@phenom.dumpdata.com> References: <1364588700-7884-1-git-send-email-konrad.wilk@oracle.com> <1364588700-7884-4-git-send-email-konrad.wilk@oracle.com> <20834.62243.599587.264214@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20834.62243.599587.264214@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: George.Dunlap@eu.citrix.com, dan.magenheimer@oracle.com, xen-devel@lists.xensource.com, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, Apr 08, 2013 at 05:41:07PM +0100, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("[Xen-devel] [PATCH 3/3] xl: 'xl info' print outstanding claims if enabled (claim_mode=1 in xl.conf)"): > > +=item B > > + > > +When a claim call is done (see L) a reservation for a specific > > +amount of pages is set and also a global value is incremented. This > > +global value (outstanding_claims) is then reduced as the domain's memory > > +is populated and eventually reaches zero. The toolstack can also choose > > +to set the domain's claim to zero which cancels the reservation and > > +decrements the global value by the amount of claim that has not been > > +satisfied. Most of the time the value will be zero, but if you are > > +launching multiple guests, and B is enabled, this value > > +can increase/decrease. > > OK, thanks, this is clear enough in general. > > But you need to explain how the user can get the toolstack to set the > domain's claim to zero. I can certainly include that. It does that once the guest has been started (also the hypervisor sets it to zero as the pages get allocated for the guest). > > And you need to explain whether the memory counted in > outstanding_claims value is _also_ counted as free memory, or as > memory belonging to its respective domain(s). Sure thing. > > > +uint64_t libxl_get_claiminfo(libxl_ctx *ctx) > > +{ > > + long l; > > + > > + l = xc_domain_get_outstanding_pages(ctx->xch); > > + if (l < 0) { > > + LIBXL__LOG_ERRNOVAL(ctx, LIBXL__LOG_WARNING, l, "xc_domain_get_outstanding_pages failed."); > > This needs wrapping to 75 columns or so. OK. Do you prefer the "xc..." to be split up or on a seperate line? > > Also, is there a way to find out which domain these claims belong to ? > I didn't see it in your previous patch. It is possible - the two patches that would have exported said information to xcinfo were dropped as I was unsure where to display this. As in I could alter 'xl list' or 'xl mem-list' to contain that information, but that would change the syntax of the printout. I don't know if that is OK? Or I can introduce a new command 'xl claim-list' ? That would give that information? > > Thanks, > Ian.