From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/7] drm/i915: PCH_NOP suspend/resume Date: Mon, 8 Apr 2013 20:57:20 +0200 Message-ID: <20130408185720.GP2228@phenom.ffwll.local> References: <1365192765-3485-1-git-send-email-ben@bwidawsk.net> <1365192765-3485-4-git-send-email-ben@bwidawsk.net> <20130406174144.GD2228@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f173.google.com (mail-ea0-f173.google.com [209.85.215.173]) by gabe.freedesktop.org (Postfix) with ESMTP id 763AEE5CD3 for ; Mon, 8 Apr 2013 11:54:22 -0700 (PDT) Received: by mail-ea0-f173.google.com with SMTP id k11so2415905eaj.18 for ; Mon, 08 Apr 2013 11:54:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130406174144.GD2228@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sat, Apr 06, 2013 at 07:41:44PM +0200, Daniel Vetter wrote: > On Fri, Apr 05, 2013 at 01:12:42PM -0700, Ben Widawsky wrote: > > More registers we can't write. > > > > Signed-off-by: Ben Widawsky > > Fixed up a minor bug (at least I think it's one) in the irq uninstall > code. Note that this is also run on gpu hangs and resume, so relevant. > > Also there's been a little conflict with Paulo's SDE irq handling fix in > -fixes. I recommend to base all feature work on top of -nightly to avoid > such issues. If there'll be a conflict when the patch applies only to > -nightly, but not dinq, I can fix this up when applying. Ok, I've embarassed myself here a bit and fixed up the ilk irq handler, which isn't run at all on ivb. I've rectified that again. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch