From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UPF94-00044Y-6x for mharc-grub-devel@gnu.org; Mon, 08 Apr 2013 12:42:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPF91-00043J-6S for grub-devel@gnu.org; Mon, 08 Apr 2013 12:42:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPF8z-0008NA-6H for grub-devel@gnu.org; Mon, 08 Apr 2013 12:42:11 -0400 Received: from mail-la0-x233.google.com ([2a00:1450:4010:c03::233]:57067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPF74-0007oE-Mn for grub-devel@gnu.org; Mon, 08 Apr 2013 12:40:10 -0400 Received: by mail-la0-f51.google.com with SMTP id fo12so693178lab.24 for ; Mon, 08 Apr 2013 09:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:subject:message-id:in-reply-to:references :x-mailer:mime-version:content-type; bh=MAL4WVPueHgF9MbuM/vjXcZ12LQxUegHX24elcMXONM=; b=mh6yYwpl/cWNuy6Hwp1nO802ZPA/duRRBaRYMUGK6wgzyKpJNksMHaBnZ2P0+8WFAj 3A9eMr7NNsyeEI61o53wH2OmDspbjkAoD4zLn4F68D0Sncj4XKZ0RVFLM8q/Ja7qHx0J Qug2cCf2ovdazOBGcOFrdqBpCm4UcvxSCPK/0o9NX3nqLzbmsoD6NKzVsr3VgGrq7nMQ EzMC8FgsKVsTvtka3eKyIahX6yNDeoo7Hf8lnp/nnQGIm1JPlAgEn6paOUYp7mtEVVuv bcg0mCcyfWVKXe3cATKQFqnO0eAr2SdjWwPqgmOuIUsd7SuKqRA4AF3xLy3OK6B9mu6N m4iA== X-Received: by 10.152.88.97 with SMTP id bf1mr6587426lab.56.1365439209541; Mon, 08 Apr 2013 09:40:09 -0700 (PDT) Received: from opensuse.site ([94.29.72.160]) by mx.google.com with ESMTPS id b2sm4549478lbv.4.2013.04.08.09.40.08 (version=SSLv3 cipher=RC4-SHA bits=128/128); Mon, 08 Apr 2013 09:40:08 -0700 (PDT) Date: Mon, 8 Apr 2013 20:40:07 +0400 From: Andrey Borzenkov To: grub-devel@gnu.org Subject: Re: Linux console corruption when booted with terminal_output=console after rev 4789 (Decrease reported width by one to compensate for cursor algorithm problem.) Message-ID: <20130408204007.3e3caa05@opensuse.site> In-Reply-To: <5162F193.1010605@gmail.com> References: <20130408195128.0e6ad1fe@opensuse.site> <5162F193.1010605@gmail.com> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.14; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/UFx6MKf+twaHFE76OaNl0.y"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::233 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2013 16:42:13 -0000 --Sig_/UFx6MKf+twaHFE76OaNl0.y Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Mon, 08 Apr 2013 18:34:27 +0200 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > On 08.04.2013 17:51, Andrey Borzenkov wrote: >=20 > > See http://susepaste.org/75296605 > >=20 > > Notice that screen width is reported as 79.=20 > >=20 > > This is absolutely reproducible with and without plymouth. > >=20 >=20 > Try this please > =3D=3D=3D modified file 'grub-core/loader/i386/linux.c' > --- grub-core/loader/i386/linux.c 2013-03-22 20:01:28 +0000 > +++ grub-core/loader/i386/linux.c 2013-04-08 16:33:08 +0000 > @@ -547,6 +547,10 @@ > linux_params.video_cursor_x =3D pos >> 8; > linux_params.video_cursor_y =3D pos & 0xff; > linux_params.video_width =3D grub_term_width (term); > +#ifdef GRUB_MACHINE_PCBIOS > + if (grub_strcmp (term->name, "console") =3D=3D 0) > + linux_params.video_width++; This is looks like piling hacks on hacks. What was wrong with my patch? Just curious. > +#endif > linux_params.video_height =3D grub_term_height (term); > found =3D 1; > break; >=20 >=20 > > _______________________________________________ > > Grub-devel mailing list > > Grub-devel@gnu.org > > https://lists.gnu.org/mailman/listinfo/grub-devel > >=20 >=20 >=20 >=20 --Sig_/UFx6MKf+twaHFE76OaNl0.y Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAlFi8ucACgkQR6LMutpd94zfPwCeIEwbT6Q4y3/KwouEhThfEx+j C3cAoM4KYSgJu+0pdT6YPvrbvMHtNK7L =e+WR -----END PGP SIGNATURE----- --Sig_/UFx6MKf+twaHFE76OaNl0.y--