From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UPFPk-0000ko-Tg for mharc-grub-devel@gnu.org; Mon, 08 Apr 2013 12:59:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPFPg-0000jS-G9 for grub-devel@gnu.org; Mon, 08 Apr 2013 12:59:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPFPf-0007Zn-AJ for grub-devel@gnu.org; Mon, 08 Apr 2013 12:59:24 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:39640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPFPe-0007ZT-W9 for grub-devel@gnu.org; Mon, 08 Apr 2013 12:59:23 -0400 Received: by mail-lb0-f173.google.com with SMTP id w20so6000798lbh.32 for ; Mon, 08 Apr 2013 09:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:subject:message-id:in-reply-to:references :x-mailer:mime-version:content-type; bh=rJEaep14B2nw+K4jMNga6f0K1rFa0CD9iXafjX1E2GM=; b=WgO17yR7HXQdYk4mv7fYNT7SwL6N0liP+N1XJEs9XGU2C9ngy05mpmFQtogImgmvJZ xO50DDfIUpgAk6T+w7RkXa86CRP5MLrUV0tBRIGMy7vHyOypZiugqnkCpziYGwIozvAw Z/HzPL5zZa6sMxXEXj4Dn7J0dg7nDNxaYSwBLO1lCresows8QUVV+gIxBTRkMBF856P4 YuCLLy6McagENXqq4jtgV4Afx+cgJmX6XrAsx+eOeEnjcGRvzGJFe7RVMvE6tgJunkT8 Y9tl25SsPqF3lYK5VbU7eDNXDtVEoBDKdgKdO8gEOpPeMgFKD5O1i0hRihn8IumDrumq hgjg== X-Received: by 10.112.125.2 with SMTP id mm2mr12061501lbb.19.1365440361635; Mon, 08 Apr 2013 09:59:21 -0700 (PDT) Received: from opensuse.site ([94.29.72.160]) by mx.google.com with ESMTPS id pk1sm11439198lab.0.2013.04.08.09.59.20 (version=SSLv3 cipher=RC4-SHA bits=128/128); Mon, 08 Apr 2013 09:59:21 -0700 (PDT) Date: Mon, 8 Apr 2013 20:59:19 +0400 From: Andrey Borzenkov To: grub-devel@gnu.org Subject: Re: Linux console corruption when booted with terminal_output=console after rev 4789 (Decrease reported width by one to compensate for cursor algorithm problem.) Message-ID: <20130408205919.016e8eda@opensuse.site> In-Reply-To: <5162F583.7010201@gmail.com> References: <20130408195128.0e6ad1fe@opensuse.site> <5162F193.1010605@gmail.com> <20130408204007.3e3caa05@opensuse.site> <5162F583.7010201@gmail.com> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.14; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/8xDPpe+DXAi/t=+Atg+iiLV"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.217.173 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2013 16:59:27 -0000 --Sig_/8xDPpe+DXAi/t=+Atg+iiLV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Mon, 08 Apr 2013 18:51:15 +0200 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > On 08.04.2013 18:40, Andrey Borzenkov wrote: >=20 > > =D0=92 Mon, 08 Apr 2013 18:34:27 +0200 > > Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF= =D0=B8=D1=88=D0=B5=D1=82: > >=20 > >> On 08.04.2013 17:51, Andrey Borzenkov wrote: > >> > >>> See http://susepaste.org/75296605 > >>> > >>> Notice that screen width is reported as 79.=20 > >>> > >>> This is absolutely reproducible with and without plymouth. > >>> > >> > >> Try this please > >> =3D=3D=3D modified file 'grub-core/loader/i386/linux.c' > >> --- grub-core/loader/i386/linux.c 2013-03-22 20:01:28 +0000 > >> +++ grub-core/loader/i386/linux.c 2013-04-08 16:33:08 +0000 > >> @@ -547,6 +547,10 @@ > >> linux_params.video_cursor_x =3D pos >> 8; > >> linux_params.video_cursor_y =3D pos & 0xff; > >> linux_params.video_width =3D grub_term_width (term); > >> +#ifdef GRUB_MACHINE_PCBIOS > >> + if (grub_strcmp (term->name, "console") =3D=3D 0) > >> + linux_params.video_width++; > >=20 > > This is looks like piling hacks on hacks. What was wrong with my patch? > > Just curious. > >=20 >=20 > Its absence. There was no patch attached to the mail or included in it. > Point me to it if I'm missing something. http://lists.gnu.org/archive/html/grub-devel/2013-02/msg00086.html=20 >=20 > >> +#endif > >> linux_params.video_height =3D grub_term_height (term); > >> found =3D 1; > >> break; > >> > >> > >>> _______________________________________________ > >>> Grub-devel mailing list > >>> Grub-devel@gnu.org > >>> https://lists.gnu.org/mailman/listinfo/grub-devel > >>> > >> > >> > >> > >=20 > >=20 > >=20 > > _______________________________________________ > > Grub-devel mailing list > > Grub-devel@gnu.org > > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 >=20 >=20 --Sig_/8xDPpe+DXAi/t=+Atg+iiLV Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAlFi92cACgkQR6LMutpd94wJNgCeN/5v6tcXs0OUv6UR/QrCCOvP FOsAnRrgZWrdq2MTpKxR3GfaK7jg30J6 =4fRF -----END PGP SIGNATURE----- --Sig_/8xDPpe+DXAi/t=+Atg+iiLV--