From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UPOlU-0006q5-84 for mharc-grub-devel@gnu.org; Mon, 08 Apr 2013 22:58:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPOlS-0006pz-9B for grub-devel@gnu.org; Mon, 08 Apr 2013 22:58:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPOlP-0002Fy-Pw for grub-devel@gnu.org; Mon, 08 Apr 2013 22:58:30 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:40685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPOlP-0002Ev-Hf for grub-devel@gnu.org; Mon, 08 Apr 2013 22:58:27 -0400 Received: by mail-lb0-f173.google.com with SMTP id w20so6436009lbh.32 for ; Mon, 08 Apr 2013 19:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:subject:message-id:in-reply-to:references :x-mailer:mime-version:content-type:content-transfer-encoding; bh=ZxqYXKkN2cQgg1JaDMs8lReZ8S+fnpVASdpeLaSulOA=; b=dqTsWArDYCfN3iN3y9Cn66LI29U4TEPfFyjsST3yVNsiVJJF93HEc0VwkckQy33SkF OgHFyum3wYFc9Wh++x6fVOkxGVRsBioEQPcDwoCMdjiNYoxFPHuyHarLQX/X8KYzM3IX CDPIvyNRbeJ82fXoATvWVyXOhnVuzzsHBdVeDs2ccEQPpBavS9BFWZ9gYNyh7tT1pJ0N HUo7ZVt7xYJbe/PEdeddsLZruL+hQXjdCdrQ7bp80AsWoxoDN9PCqz6LBvP0vWVulW/B Cr+oh6NP+RU4WALyqLkYy+/oMTDXipU6MJjvjxLwtt//3ejLAJpZ2kJW9kC+HzjFKR3Q As6w== X-Received: by 10.112.135.194 with SMTP id pu2mr3353551lbb.90.1365476305252; Mon, 08 Apr 2013 19:58:25 -0700 (PDT) Received: from opensuse.site ([94.29.72.160]) by mx.google.com with ESMTPS id iq6sm12192762lab.10.2013.04.08.19.58.24 (version=SSLv3 cipher=RC4-SHA bits=128/128); Mon, 08 Apr 2013 19:58:24 -0700 (PDT) Date: Tue, 9 Apr 2013 06:58:22 +0400 From: Andrey Borzenkov To: grub-devel@gnu.org Subject: Re: [PATCH] add elfXX.c as extra_dist to grub-core/Makefile.core.def Message-ID: <20130409065822.156b669f@opensuse.site> In-Reply-To: <1365279753-4915-1-git-send-email-arvidjaar@gmail.com> References: <1365279753-4915-1-git-send-email-arvidjaar@gmail.com> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.14; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.217.173 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2013 02:58:31 -0000 В Sun, 7 Apr 2013 00:22:33 +0400 Andrey Borzenkov пишет: > [ 327s] gcc -E -DGRUB_LST_GENERATOR -Dgrub_fs_register=FS_LIST_MARKER -Dgrub_video_register=VIDEO_LIST_MARKER -Dgrub_parttool_register=PARTTOOL_LIST_MARKER -Dgrub_partition_map_register=PARTMAP_LIST_MARKER \ > '-Dgrub_term_register_input(...)=INPUT_TERMINAL_LIST_MARKER(__VA_ARGS__)' '-Dgrub_term_register_output(...)=OUTPUT_TERMINAL_LIST_MARKER(__VA_ARGS__)' '-Dgrub_register_command(...)=COMMAND_LIST_MARKER(__VA_ARGS__)' '-Dgrub_register_extcmd(...)=EXTCOMMAND_LIST_MARKER(__VA_ARGS__)' '-Dgrub_register_command_p1(...)=P1COMMAND_LIST_MARKER(__VA_ARGS__)' \ > -DHAVE_CONFIG_H -I. -I../../grub-core -I.. -Wall -W -I../../include -I../include -DGRUB_MACHINE_EFI=1 -DGRUB_MACHINE=X86_64_EFI -DGRUB_TARGET_CPU_X86_64=1 -m64 -nostdinc -isystem /usr/lib64/gcc/x86_64-suse-linux/4.7/include -DGRUB_FILE=\"kern/elf.c\" -I. -I../../grub-core -I.. -I../.. -I../../include -I../include -I../../grub-core/lib/libgcrypt-grub/include -I../../grub-core/lib/libgcrypt-grub/src/ ../../grub-core/kern/elf.c > elf.marker.new || (rm -f elf.marker; exit 1) > [ 327s] ../../grub-core/kern/elf.c:132:19: fatal error: elfXX.c: No such file or directory > Ping. This makes it impossible to compile from dist tarball. I wish we had something like extra_deps instead (to correctly trigger make when included file changes) but I'm not yet sure about proper make magic. > Signed-off-by: Andrey Borzenkov > > --- > ChangeLog | 5 +++++ > grub-core/Makefile.core.def | 2 ++ > 2 files changed, 7 insertions(+) > > diff --git a/ChangeLog b/ChangeLog > index 9163911..486271b 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2013-04-07 Andrey Borzenkov > + > + * grub-core/Makefile.core.def: Add kern/elfXX.c to elf module > + as extra_dist. > + > 2013-04-06 Andrey Borzenkov > > * conf/Makefile.extra-dist (EXTRA_DIST): Add > diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def > index 4b4c024..fece882 100644 > --- a/grub-core/Makefile.core.def > +++ b/grub-core/Makefile.core.def > @@ -1316,6 +1316,8 @@ module = { > module = { > name = elf; > common = kern/elf.c; > + > + extra_dist = kern/elfXX.c; > }; > > module = {