From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fw-tnat.cambridge.arm.com ([217.140.96.21]:55331 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935228Ab3DII0G (ORCPT ); Tue, 9 Apr 2013 04:26:06 -0400 Date: Tue, 9 Apr 2013 09:25:32 +0100 From: Andrew Murray To: Thierry Reding Cc: Bjorn Helgaas , Thomas Petazzoni , Grant Likely , Russell King , "linux-pci@vger.kernel.org" , linux-arm , "devicetree-discuss@lists.ozlabs.org" , Lior Amsalem , Andrew Lunn , Jason Cooper , Arnd Bergmann , Maen Suleiman , Gregory Clement , Ezequiel Garcia , Olof Johansson , Tawfik Bayouk , Jason Gunthorpe , Mitch Bradley Subject: Re: [RFCv1 08/11] PCI: Introduce new MSI chip infrastructure Message-ID: <20130409082532.GA31140@arm.com> References: <1364316746-8702-1-git-send-email-thomas.petazzoni@free-electrons.com> <1364316746-8702-9-git-send-email-thomas.petazzoni@free-electrons.com> <20130409081119.GA30736@arm.com> <20130409082232.GC27255@avionic-0098.mockup.avionic-design.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20130409082232.GC27255@avionic-0098.mockup.avionic-design.de> Sender: linux-pci-owner@vger.kernel.org List-ID: On Tue, Apr 09, 2013 at 09:22:33AM +0100, Thierry Reding wrote: > On Tue, Apr 09, 2013 at 09:11:19AM +0100, Andrew Murray wrote: > [...] > > Also I believe pci_alloc_child_bus function would need to be changed to add > > "b->msi = msi" to inherit msi_chip for child buses in the above patch? > > The patch already does: > > child->msi = parent->msi; > > in pci_alloc_child_bus(), the same way that ops is inherited. I have > admittedly only tested this code on Tegra, but I don't see why that > wouldn't be enough. Or maybe I haven't understood your question? Sorry I missed that part of your patch - that was exacatly what I was hoping to see. Andrew Murray From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew.murray@arm.com (Andrew Murray) Date: Tue, 9 Apr 2013 09:25:32 +0100 Subject: [RFCv1 08/11] PCI: Introduce new MSI chip infrastructure In-Reply-To: <20130409082232.GC27255@avionic-0098.mockup.avionic-design.de> References: <1364316746-8702-1-git-send-email-thomas.petazzoni@free-electrons.com> <1364316746-8702-9-git-send-email-thomas.petazzoni@free-electrons.com> <20130409081119.GA30736@arm.com> <20130409082232.GC27255@avionic-0098.mockup.avionic-design.de> Message-ID: <20130409082532.GA31140@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Apr 09, 2013 at 09:22:33AM +0100, Thierry Reding wrote: > On Tue, Apr 09, 2013 at 09:11:19AM +0100, Andrew Murray wrote: > [...] > > Also I believe pci_alloc_child_bus function would need to be changed to add > > "b->msi = msi" to inherit msi_chip for child buses in the above patch? > > The patch already does: > > child->msi = parent->msi; > > in pci_alloc_child_bus(), the same way that ops is inherited. I have > admittedly only tested this code on Tegra, but I don't see why that > wouldn't be enough. Or maybe I haven't understood your question? Sorry I missed that part of your patch - that was exacatly what I was hoping to see. Andrew Murray From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Murray Subject: Re: [RFCv1 08/11] PCI: Introduce new MSI chip infrastructure Date: Tue, 9 Apr 2013 09:25:32 +0100 Message-ID: <20130409082532.GA31140@arm.com> References: <1364316746-8702-1-git-send-email-thomas.petazzoni@free-electrons.com> <1364316746-8702-9-git-send-email-thomas.petazzoni@free-electrons.com> <20130409081119.GA30736@arm.com> <20130409082232.GC27255@avionic-0098.mockup.avionic-design.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20130409082232.GC27255@avionic-0098.mockup.avionic-design.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Thierry Reding Cc: Thomas Petazzoni , Lior Amsalem , Russell King , Jason Cooper , Arnd Bergmann , Andrew Lunn , "linux-pci@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , Olof Johansson , Grant Likely , Maen Suleiman , Ezequiel Garcia , Bjorn Helgaas , Gregory Clement , Tawfik Bayouk , Mitch Bradley , linux-arm , Jason Gunthorpe List-Id: devicetree@vger.kernel.org On Tue, Apr 09, 2013 at 09:22:33AM +0100, Thierry Reding wrote: > On Tue, Apr 09, 2013 at 09:11:19AM +0100, Andrew Murray wrote: > [...] > > Also I believe pci_alloc_child_bus function would need to be changed to add > > "b->msi = msi" to inherit msi_chip for child buses in the above patch? > > The patch already does: > > child->msi = parent->msi; > > in pci_alloc_child_bus(), the same way that ops is inherited. I have > admittedly only tested this code on Tegra, but I don't see why that > wouldn't be enough. Or maybe I haven't understood your question? Sorry I missed that part of your patch - that was exacatly what I was hoping to see. Andrew Murray