All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Brillault <gentoo@lerya.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: Warnings with ASUS PCE-N15 (RTL8188CE)
Date: Tue, 9 Apr 2013 11:47:02 +0200	[thread overview]
Message-ID: <20130409094542.GA26503@Fea.lerya.net> (raw)
In-Reply-To: <5150AE0F.2040306@lwfinger.net>

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

Hi again :)

On Mon 25.Mar'13 at 15:05:35 -0500, Larry Finger wrote:
> I will let you change that G to a B and test some more. If all goes well, then I 
> will not need to set up that test bed, but at least I have the necessary details 
> if ever required.

I changed it from G to B. Now the rate (in iwconfig) is fixed to 11
Mb/s, but that's not a problem as you said it's not the real rate. I
didn't see any warning on module loading since that modification :)

I still have the deconnection/reconnection issue. After looking on the
reason, I think I have found a bug. Please look at the patched included
in this mail: I think the rtlpriv->link_info.num_rx_inperiod is set to 0
too early, as the '/* <4> roaming */' part uses it to see if the AP is
still alive. What do you think ?

Best,
Vincent

[-- Attachment #2: rtlwifi-watchdog-rx_inperiod.patch --]
[-- Type: text/x-diff, Size: 687 bytes --]

diff --git a/drivers/net/wireless/rtlwifi/base.c b/drivers/net/wireless/rtlwifi/base.c
index cac1fa9..d540938 100644
--- a/drivers/net/wireless/rtlwifi/base.c
+++ b/drivers/net/wireless/rtlwifi/base.c
@@ -1411,7 +1411,6 @@ void rtl_watchdog_wq_callback(void *data)
 		schedule_work(&rtlpriv->works.lps_change_work);
 	}
 
-	rtlpriv->link_info.num_rx_inperiod = 0;
 	rtlpriv->link_info.num_tx_inperiod = 0;
 	for (tid = 0; tid <= 7; tid++)
 		rtlpriv->link_info.tidtx_inperiod[tid] = 0;
@@ -1448,6 +1447,7 @@ void rtl_watchdog_wq_callback(void *data)
 			rtlpriv->link_info.roam_times = 0;
 		}
 	}
+	rtlpriv->link_info.num_rx_inperiod = 0;
 	rtlpriv->link_info.bcn_rx_inperiod = 0;
 }
 

  reply	other threads:[~2013-04-09  9:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07 19:29 Warnings with ASUS PCE-N15 (RTL8188CE) Vincent Brillault
2013-03-08 21:58 ` Vincent Brillault
2013-03-09  1:53   ` Larry Finger
2013-03-09 11:32     ` Vincent Brillault
2013-03-09 18:24       ` Larry Finger
2013-03-11 18:38         ` Vincent Brillault
2013-03-13  8:00           ` Vincent Brillault
2013-03-17 14:12             ` Vincent Brillault
2013-03-25 18:29               ` Vincent Brillault
2013-03-25 19:11                 ` Larry Finger
2013-03-25 19:51                   ` Vincent Brillault
2013-03-25 20:05                     ` Larry Finger
2013-04-09  9:47                       ` Vincent Brillault [this message]
2013-04-09 15:32                         ` Larry Finger
2013-04-09 16:04                           ` Vincent Brillault
2013-04-09 18:03                             ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130409094542.GA26503@Fea.lerya.net \
    --to=gentoo@lerya.net \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.