From: Theodore Ts'o <tytso@mit.edu>
To: Eric Whitney <enwlinux@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: fix free space estimate in ext4_nonda_switch()
Date: Tue, 9 Apr 2013 09:28:19 -0400 [thread overview]
Message-ID: <20130409132819.GD12050@thunk.org> (raw)
In-Reply-To: <20130403171931.GC3006@wallace>
On Wed, Apr 03, 2013 at 01:19:31PM -0400, Eric Whitney wrote:
> Values stored in s_freeclusters_counter and s_dirtyclusters_counter
> are both in cluster units. Remove the cluster to block conversion
> applied to s_freeclusters_counter causing an inflated estimate of
> free space because s_dirtyclusters_counter is not similarly
> converted. Rename free_blocks and dirty_blocks to better reflect
> the units these variables contain to avoid future confusion. This
> fix corrects ENOSPC failures for xfstests 127 and 231 on bigalloc
> file systems.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Hi Eric,
This patch looks good. Thanks for submitting it!!
I've applied it to the dev branch for testing.
- Ted
prev parent reply other threads:[~2013-04-09 13:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 17:19 [PATCH] ext4: fix free space estimate in ext4_nonda_switch() Eric Whitney
2013-04-09 13:28 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409132819.GD12050@thunk.org \
--to=tytso@mit.edu \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.