From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: Move quota initialization out of inode allocation transaction
Date: Tue, 9 Apr 2013 12:42:37 -0400 [thread overview]
Message-ID: <20130409164237.GC5980@thunk.org> (raw)
In-Reply-To: <1365496448-9907-2-git-send-email-jack@suse.cz>
On Tue, Apr 09, 2013 at 10:34:08AM +0200, Jan Kara wrote:
> Inode allocation transaction is pretty heavy (246 credits with quotas
> and extents before previous patch, still around 200 after it). This is
> mostly due to credits required for allocation of quota structures
> (credits there are heavily overestimated but it's difficult to make
> better estimates if we don't want to wire non-trivial assumptions about
> quota format into filesystem).
>
> So move quota initialization out of allocation transaction. That way
> transaction for quota structure allocation will be started only if we
> need to look up quota structure on disk (rare) and furthermore it will
> be started for each quota type separately, not for all of them at once.
> This reduces maximum transaction size to 34 is most cases and to 73 in
> the worst case.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Thanks, added to the dev branch for testing.
- Ted
next prev parent reply other threads:[~2013-04-09 16:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 8:34 [PATCH 1/2] ext4: Improve credit estimate for EXT4_SINGLEDATA_TRANS_BLOCKS Jan Kara
2013-04-09 8:34 ` [PATCH 2/2] ext4: Move quota initialization out of inode allocation transaction Jan Kara
2013-04-09 16:42 ` Theodore Ts'o [this message]
2013-04-18 19:07 ` Theodore Ts'o
2013-04-18 21:46 ` Jan Kara
2013-04-18 23:24 ` [PATCH -v3] ext4: move " Theodore Ts'o
2013-04-19 14:30 ` Jan Kara
2013-04-19 16:24 ` Theodore Ts'o
2013-04-19 19:21 ` Jan Kara
2013-04-09 16:42 ` [PATCH 1/2] ext4: Improve credit estimate for EXT4_SINGLEDATA_TRANS_BLOCKS Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409164237.GC5980@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.