From: Vivek Goyal <vgoyal@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
WANG Chao <chaowang@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/4] x86, kdump: Change crashkernel_high/low= to crashkernel=;high/low
Date: Tue, 9 Apr 2013 16:29:48 -0400 [thread overview]
Message-ID: <20130409202948.GQ6320@redhat.com> (raw)
In-Reply-To: <5164790E.7@zytor.com>
On Tue, Apr 09, 2013 at 01:24:46PM -0700, H. Peter Anvin wrote:
> On 04/09/2013 01:05 PM, Yinghai Lu wrote:
> >>
> >> So crashkernel=X@Y;high is a valid syntax? Looks like we will reserve
> >> X amount of RAM at base Y and ignore "high" or "low".
> >
> > yes, we should reject them.
> >
>
> What if there isn't X amount of RAM available at base Y?
We don't reserve anything.
In this context crashkernel=X@Y,high is invalid syntax and should probably
be ignored by parser. The very fact user specified the offset, high or
low option does not carry any meaning.
crashkernel=X,high is valid though.
Thanks
Vivek
next prev parent reply other threads:[~2013-04-09 20:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 22:16 [PATCH -v3 0/4] x86, kdump: Fix crashkernel high with old kexec-tools Yinghai Lu
2013-04-04 22:16 ` [PATCH v3 1/4] x86, kdump: Set crashkernel_low automatically Yinghai Lu
2013-04-08 7:09 ` Dave Young
2013-04-08 18:37 ` Yinghai Lu
2013-04-09 3:25 ` Dave Young
2013-04-09 3:37 ` Yinghai Lu
2013-04-04 22:16 ` [PATCH v3 4/4] kexec: use Crash kernel for Crash kernel low Yinghai Lu
2013-04-04 22:17 ` [PATCH v3 2/4] x86, kdump: Retore crashkernel= to allocate under 896M Yinghai Lu
2013-04-04 22:17 ` [PATCH v3 3/4] x86, kdump: Change crashkernel_high/low= to crashkernel=;high/low Yinghai Lu
2013-04-09 13:45 ` Vivek Goyal
2013-04-09 15:00 ` H. Peter Anvin
2013-04-09 16:47 ` Vivek Goyal
2013-04-09 16:49 ` H. Peter Anvin
2013-04-09 17:00 ` Vivek Goyal
2013-04-09 17:12 ` Vivek Goyal
2013-04-09 17:20 ` H. Peter Anvin
2013-04-09 20:05 ` Yinghai Lu
2013-04-09 20:24 ` H. Peter Anvin
2013-04-09 20:29 ` Vivek Goyal [this message]
2013-04-09 20:33 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409202948.GQ6320@redhat.com \
--to=vgoyal@redhat.com \
--cc=chaowang@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.