From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?utf-8?q?St=C3=BCbner?= Subject: Re: [PATCH v2 0/3] ARM: S3C24XX: Add devicetree support for s3c2416 Date: Wed, 10 Apr 2013 12:37:31 +0200 Message-ID: <201304101237.31874.heiko@sntech.de> References: <201302180103.53084.heiko@sntech.de> <30ff01ce35d4$5f4920d0$1ddb6270$%kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <30ff01ce35d4$5f4920d0$1ddb6270$%kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Kukjin Kim Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, 'Rob Herring' , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-samsung-soc@vger.kernel.org QW0gTWl0dHdvY2gsIDEwLiBBcHJpbCAyMDEzLCAxMjoxNTo0OCBzY2hyaWViIEt1a2ppbiBLaW06 Cj4gSGVpa28gU3TDvGJuZXIgd3JvdGU6Cj4gPiBUaGlzIGlzIHRoZSBzZWNvbmQgaW5zdGFsbG1l bnQgb2YgYmVnaW5uaW5nIGRldmljZXRyZWUgc3VwcG9ydCB0aGUKPiA+IFNhbXN1bmcgUzNDMjR4 eCBhcmNoaXRlY3R1cmVzIGFuZCBmb2N1c2VzIG9uIHRoZSBzM2MyNDE2IGZvciBub3cuCj4gPiAK PiA+IEluY2x1ZGVkIGlzIHRoZSBkZXZpY2V0cmVlIHN1cHBvcnQgZm9yIHRoZSBzM2MyNHh4IGly cSBjb250cm9sbGVyIGFuZAo+ID4gYmFzaWMgc3VwcG9ydCBmb3Igc21kazI0MTYgYm9hcmRzLCB3 aGljaCBjYW4gc3VjZXNzZnVsbHkgYm9vdC4KPiA+IAo+ID4gCj4gPiBBZnRlciB0aGUgZGlzY3Vz c2lvbiB3aXRoIFRob21hcyBBYnJhaGFtIG9uIHYxIGFuZCBzdGFyaW5nIHRvIGxvbmcgYXQgYWxs Cj4gPiBvZgo+ID4gdGhpcywgSSdtIG5vdCBldmVuIHN1cmUgaWYgaGF2aW5nIHRoZSBpbnRlcnJ1 cHQgbWFwcGluZyBpbiB0aGUgYmluZGluZwo+ID4gaXMgdGhlIGNvcnJlY3Qgd2F5IHRvIGdvIGFu eW1vcmUuCj4gPiAKPiA+IFRoZSBrZXkgcG9zaXRpdmUgYXNwZWN0IG9mIHRoaXMgc29sdXRpb24g aXMsIHRoYXQgYWZ0ZXIgZXZlcnl0aGluZyBpcwo+ID4gcnVubmluZwo+ID4gdmlhIGR0IGFsbCB0 aGUgU29DIHNwZWNpZmljIG1hcHBpbmcgdGFibGVzIGluIHRoZSBkcml2ZXIgY2FuIGdvIGF3YXks Cj4gPiBjdXR0aW5nCj4gPiBpdHMgbGVuZ3RoIGluIGhhbGYuCj4gPiAKPiA+IFRoZSBvdGhlciBv cHRpb24gd291bGQgYmUgYXMgVGhvbWFzIHN1Z2dlc3RlZCB0byBkZWZpbmUgc3BlY2lmaWMgaXJx LQo+ID4gY29udHJvbGxlcgo+ID4gdHlwZXMgKGkuZS4gczNjMjQxNi1pbnRjLCBzM2MyNDQzLWlu dGMsIC4uLiByZXN1bHRpbmcgaW4gMTYgdHlwZXMpIGFuZAo+ID4ga2VlcAo+ID4gdGhlIG1hcHBp bmcgZGF0YSBpbiB0aGUgY29kZSwgYXMgaXQgaXMgbm93Lgo+ID4gCj4gPiBTbyBJIHdvdWxkIGJl IHZlcnkgdGhhbmtmdWwgZm9yIGEgYml0IG9mIGd1aWRhbmNlIG9uIHdoYXQgaXMgdGhlIGJldHRl cgo+ID4gd2F5Lgo+ID4gCj4gPiAKPiA+IFRoZSBzZXJpZXMgZGVwZW5kcyBvbiB0aGUgZmluYWxp emVkIHMzYzI0eHggaXJxIHJld29yaywgd2hpY2ggcHJvYmFibHkKPiA+IHdvbid0Cj4gPiBtYWtl IGl0IGludG8gMy45IGFuZCBhbHNvIHRoZSBjbG9ja3NvdXJjZSBkdCBzdXBwb3J0IGJ5IFRvbWFz eiBGaWdhLAo+ID4gd2hpY2ggYXJlIG5vdCBpbiBhbnkgdHJlZSB5ZXQuCj4gPiAKPiA+IAo+ID4g Q2hhbmdlcyBzaW5jZSB2MToKPiA+IC0gYWRhcHQgdG8gY2hhbmdlcyBpbiB0aGUgdW5kZXJseWlu ZyBzM2MyNHh4IGlycSByZXdvcmsKPiA+IAo+ID4gICA9IG1vcmUgc2hhcmVkIGluaXQgY29kZQo+ ID4gCj4gPiAtIHVzZSBpcnFjaGlwIGluZnJhc3RydWN0dXJlCj4gPiAtIGxpbWl0IG51bWJlciBv ZiBwb3NzaWJsZSBpcnEtdHlwZXMgdG8gbm90IGVuY29kZSBpbXBsZW1lbnRhdGlvbiBkZXRhaWxz Cj4gPiAKPiA+ICAgaW50byB0aGUgYmluZGluZwo+ID4gCj4gPiAtIGluY2x1ZGUgbmV3IHNhbXN1 bmctY2xvY2tzb3VyY2UKPiA+IAo+ID4gSGVpa28gU3R1ZWJuZXIgKDMpOgo+ID4gICBBUk06IFMz QzI0WFg6IG1vdmUgaXJxIGRyaXZlciB0byBkcml2ZXJzL2lycWNoaXAKPiA+ICAgaXJxY2hpcDog aXJxLXMzYzI0eHg6IGFkZCBkZXZpY2V0cmVlIHN1cHBvcnQKPiA+ICAgQVJNOiBTM0MyNFhYOiBB ZGQgZGV2aWNldHJlZSBzdXBwb3J0IGFuZCBkdC1ib2FyZCBmaWxlIGZvciBzM2MyNDE2IFNvQ3MK PiA+ICAKPiA+ICAuLi4vaW50ZXJydXB0LWNvbnRyb2xsZXIvc2Ftc3VuZyxzM2MyNHh4LWlycS50 eHQgICB8ICAgNTMgKysrKysrCj4gPiAgYXJjaC9hcm0vYm9vdC9kdHMvTWFrZWZpbGUgICAgICAg ICAgICAgICAgICAgICAgICAgfCAgICAxICsKPiA+ICBhcmNoL2FybS9ib290L2R0cy9zM2MyNDE2 LXNtZGsyNDE2LmR0cyAgICAgICAgICAgICB8ICAgNzkgKysrKysrKysKPiA+ICBhcmNoL2FybS9i b290L2R0cy9zM2MyNDE2LmR0c2kgICAgICAgICAgICAgICAgICAgICB8ICAxOTMKPiA+ICArKysr KysrKysrKysrKysrKysrKyBhcmNoL2FybS9ib290L2R0cy9zM2MyNHh4LmR0c2kgICAgICAgICAg ICAgICAgICAgIAo+ID4gIHwgIDE2NSArKysrKysrKysrKysrKysrKyBhcmNoL2FybS9tYWNoLXMz YzI0eHgvS2NvbmZpZyAgICAgICAgICAgICAgICAgCj4gPiAgICAgIHwgICAxMCArCj4gPiAgYXJj aC9hcm0vbWFjaC1zM2MyNHh4L01ha2VmaWxlICAgICAgICAgICAgICAgICAgICAgfCAgICAzICst Cj4gPiAgYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtczNjMjQxNi1kdC5jICAgICAgICAgICAg fCAgIDkxICsrKysrKysrKwo+ID4gIGRyaXZlcnMvaXJxY2hpcC9NYWtlZmlsZSAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAgMSArCj4gPiAgLi4uL2lycS5jID0+IGRyaXZlcnMvaXJxY2hp cC9pcnEtczNjMjR4eC5jICAgICAgICAgfCAgMTI4ICsrKysrKysrKysrKysKPiA+ICAxMCBmaWxl cyBjaGFuZ2VkLCA3MjMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKPiA+ICBjcmVhdGUg bW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2ludGVycnVwdC0K PiA+IAo+ID4gY29udHJvbGxlci9zYW1zdW5nLHMzYzI0eHgtaXJxLnR4dAo+ID4gCj4gPiAgY3Jl YXRlIG1vZGUgMTAwNjQ0IGFyY2gvYXJtL2Jvb3QvZHRzL3MzYzI0MTYtc21kazI0MTYuZHRzCj4g PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGFyY2gvYXJtL2Jvb3QvZHRzL3MzYzI0MTYuZHRzaQo+ID4g IGNyZWF0ZSBtb2RlIDEwMDY0NCBhcmNoL2FybS9ib290L2R0cy9zM2MyNHh4LmR0c2kKPiA+ICBj cmVhdGUgbW9kZSAxMDA2NDQgYXJjaC9hcm0vbWFjaC1zM2MyNHh4L21hY2gtczNjMjQxNi1kdC5j Cj4gPiAgcmVuYW1lIGFyY2gvYXJtL21hY2gtczNjMjR4eC9pcnEuYyA9PiBkcml2ZXJzL2lycWNo aXAvaXJxLXMzYzI0eHguYwo+ID4gICg5MiUpCj4gPiAKPiA+IC0tCj4gPiAxLjcuMi4zCj4gCj4g QmFzaWNhbGx5LCBsb29rcyBnb29kIHRvIG1lIGFuZCB0aGFua3MgZm9yIHlvdXIgZWZmb3J0Lgo+ IAo+IEJUVywgaWYgeW91IGRvbid0IG1pbmQsIHdvdWxkIGJlIGJldHRlciB0byBzZW5kIHRvIHVw c3RyZWFtIG5leHQgdGltZS4KPiBCZWNhdXNlIEkgbmVlZCB0byBjb25zaWRlciBvdGhlciBzM2My NHh4IFNvQ3MgZm9yIERULi4uCgpoZWhlLCB5b3UncmUgZGlnZ2luZyB1cCBxdWl0ZSBvbGQgc3R1 ZmYgOi0pCgpUaGlzIG9mIGNvdXJzZSBnb3Qgc3VwZXJzZWVkZWQgYnkgdGhlIGRpZmZlcmVudCBh cHByb2FjaCB0byBzM2MyNHh4LWlycSBkdC0Kc3VwcG9ydCBhbmQgdGhlIHBpbmN0cmwgd29yay4K CkknbGwgc2VuZCBhIG5ldyB2ZXJzaW9uIG9mIHRoZSBkdCBzdXBwb3J0IHdoaWNoIHRha2VzIGlu dG8gYWNjb3VudCBhbGwgdGhlIApyZWNlbnQgY2hhbmdlcyBpbiB0aGUgbmV4dCBjb3VwbGUgb2Yg ZGF5cy4KCk9mIGNvdXJzZSBJJ20gb2sgd2l0aCBkZWxheWluZyB0aGlzIHVudGlsIDMuMTEuIEF0 IGxlYXN0IGFsbCB0aGUgYnVpbGRpbmcgCmJsb2NrcyAoaXJxIGFuZCBwaW5jdHJsKSBhcmUgdGhl cmUgbm93LgoKCkhlaWtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRldmljZXRyZWUtZGlzY3VzcyBtYWlsaW5nIGxpc3QKZGV2aWNldHJlZS1kaXNjdXNz QGxpc3RzLm96bGFicy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2Rldmlj ZXRyZWUtZGlzY3Vzcwo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?utf-8?q?St=C3=BCbner?=) Date: Wed, 10 Apr 2013 12:37:31 +0200 Subject: [PATCH v2 0/3] ARM: S3C24XX: Add devicetree support for s3c2416 In-Reply-To: <30ff01ce35d4$5f4920d0$1ddb6270$%kim@samsung.com> References: <201302180103.53084.heiko@sntech.de> <30ff01ce35d4$5f4920d0$1ddb6270$%kim@samsung.com> Message-ID: <201304101237.31874.heiko@sntech.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Mittwoch, 10. April 2013, 12:15:48 schrieb Kukjin Kim: > Heiko St?bner wrote: > > This is the second installment of beginning devicetree support the > > Samsung S3C24xx architectures and focuses on the s3c2416 for now. > > > > Included is the devicetree support for the s3c24xx irq controller and > > basic support for smdk2416 boards, which can sucessfully boot. > > > > > > After the discussion with Thomas Abraham on v1 and staring to long at all > > of > > this, I'm not even sure if having the interrupt mapping in the binding > > is the correct way to go anymore. > > > > The key positive aspect of this solution is, that after everything is > > running > > via dt all the SoC specific mapping tables in the driver can go away, > > cutting > > its length in half. > > > > The other option would be as Thomas suggested to define specific irq- > > controller > > types (i.e. s3c2416-intc, s3c2443-intc, ... resulting in 16 types) and > > keep > > the mapping data in the code, as it is now. > > > > So I would be very thankful for a bit of guidance on what is the better > > way. > > > > > > The series depends on the finalized s3c24xx irq rework, which probably > > won't > > make it into 3.9 and also the clocksource dt support by Tomasz Figa, > > which are not in any tree yet. > > > > > > Changes since v1: > > - adapt to changes in the underlying s3c24xx irq rework > > > > = more shared init code > > > > - use irqchip infrastructure > > - limit number of possible irq-types to not encode implementation details > > > > into the binding > > > > - include new samsung-clocksource > > > > Heiko Stuebner (3): > > ARM: S3C24XX: move irq driver to drivers/irqchip > > irqchip: irq-s3c24xx: add devicetree support > > ARM: S3C24XX: Add devicetree support and dt-board file for s3c2416 SoCs > > > > .../interrupt-controller/samsung,s3c24xx-irq.txt | 53 ++++++ > > arch/arm/boot/dts/Makefile | 1 + > > arch/arm/boot/dts/s3c2416-smdk2416.dts | 79 ++++++++ > > arch/arm/boot/dts/s3c2416.dtsi | 193 > > ++++++++++++++++++++ arch/arm/boot/dts/s3c24xx.dtsi > > | 165 +++++++++++++++++ arch/arm/mach-s3c24xx/Kconfig > > | 10 + > > arch/arm/mach-s3c24xx/Makefile | 3 +- > > arch/arm/mach-s3c24xx/mach-s3c2416-dt.c | 91 +++++++++ > > drivers/irqchip/Makefile | 1 + > > .../irq.c => drivers/irqchip/irq-s3c24xx.c | 128 +++++++++++++ > > 10 files changed, 723 insertions(+), 1 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/interrupt- > > > > controller/samsung,s3c24xx-irq.txt > > > > create mode 100644 arch/arm/boot/dts/s3c2416-smdk2416.dts > > create mode 100644 arch/arm/boot/dts/s3c2416.dtsi > > create mode 100644 arch/arm/boot/dts/s3c24xx.dtsi > > create mode 100644 arch/arm/mach-s3c24xx/mach-s3c2416-dt.c > > rename arch/arm/mach-s3c24xx/irq.c => drivers/irqchip/irq-s3c24xx.c > > (92%) > > > > -- > > 1.7.2.3 > > Basically, looks good to me and thanks for your effort. > > BTW, if you don't mind, would be better to send to upstream next time. > Because I need to consider other s3c24xx SoCs for DT... hehe, you're digging up quite old stuff :-) This of course got superseeded by the different approach to s3c24xx-irq dt- support and the pinctrl work. I'll send a new version of the dt support which takes into account all the recent changes in the next couple of days. Of course I'm ok with delaying this until 3.11. At least all the building blocks (irq and pinctrl) are there now. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937250Ab3DJKhp (ORCPT ); Wed, 10 Apr 2013 06:37:45 -0400 Received: from gloria.sntech.de ([95.129.55.99]:42608 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935405Ab3DJKhm (ORCPT ); Wed, 10 Apr 2013 06:37:42 -0400 From: Heiko =?utf-8?q?St=C3=BCbner?= To: Kukjin Kim Subject: Re: [PATCH v2 0/3] ARM: S3C24XX: Add devicetree support for s3c2416 Date: Wed, 10 Apr 2013 12:37:31 +0200 User-Agent: KMail/1.13.7 (Linux/3.2.0-3-686-pae; KDE/4.8.4; i686; ; ) Cc: "'Grant Likely'" , "'Rob Herring'" , "'Thomas Abraham'" , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <201302180103.53084.heiko@sntech.de> <30ff01ce35d4$5f4920d0$1ddb6270$%kim@samsung.com> In-Reply-To: <30ff01ce35d4$5f4920d0$1ddb6270$%kim@samsung.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <201304101237.31874.heiko@sntech.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 10. April 2013, 12:15:48 schrieb Kukjin Kim: > Heiko Stübner wrote: > > This is the second installment of beginning devicetree support the > > Samsung S3C24xx architectures and focuses on the s3c2416 for now. > > > > Included is the devicetree support for the s3c24xx irq controller and > > basic support for smdk2416 boards, which can sucessfully boot. > > > > > > After the discussion with Thomas Abraham on v1 and staring to long at all > > of > > this, I'm not even sure if having the interrupt mapping in the binding > > is the correct way to go anymore. > > > > The key positive aspect of this solution is, that after everything is > > running > > via dt all the SoC specific mapping tables in the driver can go away, > > cutting > > its length in half. > > > > The other option would be as Thomas suggested to define specific irq- > > controller > > types (i.e. s3c2416-intc, s3c2443-intc, ... resulting in 16 types) and > > keep > > the mapping data in the code, as it is now. > > > > So I would be very thankful for a bit of guidance on what is the better > > way. > > > > > > The series depends on the finalized s3c24xx irq rework, which probably > > won't > > make it into 3.9 and also the clocksource dt support by Tomasz Figa, > > which are not in any tree yet. > > > > > > Changes since v1: > > - adapt to changes in the underlying s3c24xx irq rework > > > > = more shared init code > > > > - use irqchip infrastructure > > - limit number of possible irq-types to not encode implementation details > > > > into the binding > > > > - include new samsung-clocksource > > > > Heiko Stuebner (3): > > ARM: S3C24XX: move irq driver to drivers/irqchip > > irqchip: irq-s3c24xx: add devicetree support > > ARM: S3C24XX: Add devicetree support and dt-board file for s3c2416 SoCs > > > > .../interrupt-controller/samsung,s3c24xx-irq.txt | 53 ++++++ > > arch/arm/boot/dts/Makefile | 1 + > > arch/arm/boot/dts/s3c2416-smdk2416.dts | 79 ++++++++ > > arch/arm/boot/dts/s3c2416.dtsi | 193 > > ++++++++++++++++++++ arch/arm/boot/dts/s3c24xx.dtsi > > | 165 +++++++++++++++++ arch/arm/mach-s3c24xx/Kconfig > > | 10 + > > arch/arm/mach-s3c24xx/Makefile | 3 +- > > arch/arm/mach-s3c24xx/mach-s3c2416-dt.c | 91 +++++++++ > > drivers/irqchip/Makefile | 1 + > > .../irq.c => drivers/irqchip/irq-s3c24xx.c | 128 +++++++++++++ > > 10 files changed, 723 insertions(+), 1 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/interrupt- > > > > controller/samsung,s3c24xx-irq.txt > > > > create mode 100644 arch/arm/boot/dts/s3c2416-smdk2416.dts > > create mode 100644 arch/arm/boot/dts/s3c2416.dtsi > > create mode 100644 arch/arm/boot/dts/s3c24xx.dtsi > > create mode 100644 arch/arm/mach-s3c24xx/mach-s3c2416-dt.c > > rename arch/arm/mach-s3c24xx/irq.c => drivers/irqchip/irq-s3c24xx.c > > (92%) > > > > -- > > 1.7.2.3 > > Basically, looks good to me and thanks for your effort. > > BTW, if you don't mind, would be better to send to upstream next time. > Because I need to consider other s3c24xx SoCs for DT... hehe, you're digging up quite old stuff :-) This of course got superseeded by the different approach to s3c24xx-irq dt- support and the pinctrl work. I'll send a new version of the dt support which takes into account all the recent changes in the next couple of days. Of course I'm ok with delaying this until 3.11. At least all the building blocks (irq and pinctrl) are there now. Heiko