From: Andy Whitcroft <apw@canonical.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Joe Perches <joe@perches.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: checkpatch: kill the bogus camelcase check
Date: Wed, 10 Apr 2013 14:26:28 +0100 [thread overview]
Message-ID: <20130410132628.GV7511@dm> (raw)
In-Reply-To: <1365544254.2946.53.camel@dabdike>
On Tue, Apr 09, 2013 at 02:50:54PM -0700, James Bottomley wrote:
> It's making checkpatch unusable on most drivers because it's spewing
> tons of bogus warnings. The problem is the assumption that studly caps
> is always wrong: it isn't if the variables are named after the various
> conventions in the hardware programming guides (which are usually
> written by Microsoft people).
>
> In order to encourage people to use checkpatch, it has to be *useful* it
> can't stray too far into dogmatic things like this that are essentially
> unfixable by most people who submit patches.
>
> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Joe, perhaps this could become a strict check?
-apw
next prev parent reply other threads:[~2013-04-10 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 21:50 checkpatch: kill the bogus camelcase check James Bottomley
2013-04-10 13:26 ` Andy Whitcroft [this message]
2013-04-10 14:35 ` Joe Perches
2013-04-10 14:52 ` Borislav Petkov
2013-04-10 15:07 ` James Bottomley
2013-04-10 15:19 ` Borislav Petkov
2013-04-11 14:45 ` [PATCH] checkpatch: Make camelcase test --strict and less noisy Joe Perches
2013-05-01 12:34 ` Borislav Petkov
2013-05-01 13:50 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410132628.GV7511@dm \
--to=apw@canonical.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.