From: Borislav Petkov <bp@alien8.de>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Stefan Bader <stefan.bader@canonical.com>,
Andy Whitcroft <apw@canonical.com>, Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] mm: pageattr: convert noop to functional fix
Date: Wed, 10 Apr 2013 15:33:46 +0200 [thread overview]
Message-ID: <20130410133346.GD6857@pd.tnic> (raw)
In-Reply-To: <1365600505-19314-1-git-send-email-aarcange@redhat.com>
On Wed, Apr 10, 2013 at 03:28:25PM +0200, Andrea Arcangeli wrote:
> Commit a8aed3e0752b4beb2e37cbed6df69faae88268da introduced some valid
> fix but one location that didn't trigger the bug that lead to finding
> those (small) problems, wasn't updated using the right variable.
>
> The wrong variable was also initialized for no good reason, that may
> have been the source of the confusion. Remove the noop initialization
> accordingly.
>
> Commit a8aed3e0752b4beb2e37cbed6df69faae88268da also erroneously
> removed one canon_pgprot pass meant to clear pmd bitflags not
> supported in hardware by older CPUs, that automatically gets corrected
> by this patch too by applying it to the right variable in the new
> location.
>
> Reported-by: Stefan Bader <stefan.bader@canonical.com>
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Acked-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-04-10 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 13:28 [PATCH] mm: pageattr: convert noop to functional fix Andrea Arcangeli
2013-04-10 13:33 ` Borislav Petkov [this message]
2013-04-11 12:20 ` [tip:x86/urgent] x86/mm/cpa: Convert " tip-bot for Andrea Arcangeli
2013-04-11 12:29 ` Ingo Molnar
2013-04-11 13:35 ` Andrea Arcangeli
2013-04-12 5:24 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410133346.GD6857@pd.tnic \
--to=bp@alien8.de \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@elte.hu \
--cc=stefan.bader@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.