From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:36359 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935568Ab3DJPZ3 (ORCPT ); Wed, 10 Apr 2013 11:25:29 -0400 Date: Wed, 10 Apr 2013 11:25:26 -0400 From: "J. Bruce Fields" To: Steve Dickson Cc: Trond Myklebust , "David P. Quigley" , Linux NFS list , Linux FS devel list , Linux Security List , SELinux List Subject: Re: [PATCH 19/19] NFSDv4.2: Added NFS v4.2 support to the NFS server Message-ID: <20130410152526.GD24404@pad.fieldses.org> References: <1364939160-20874-1-git-send-email-SteveD@redhat.com> <1364939160-20874-20-git-send-email-SteveD@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1364939160-20874-20-git-send-email-SteveD@redhat.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Tue, Apr 02, 2013 at 05:46:00PM -0400, Steve Dickson wrote: > From: Steve Dickson > > This enable NFSv4.2 support for the server. To enable this > code do the following: > echo "+4.2" >/proc/fs/nfsd/versions The patches are ordered strangely: labeled nFS support depends on 4.2 support, so we should be adding 4.2 support first, then labeled NFS support on top of that. Note a 4.1 client shouldn't see the server return the new attribute as supported unless it's using 4.2, and attempts to set it should error out unless it's using 4.2. --b. > > after the nfsd kernel module is loaded. > > Signed-off-by: Steve Dickson > --- > fs/nfsd/nfs4xdr.c | 1 + > fs/nfsd/nfsd.h | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c > index 818c1ca..d40b6ac 100644 > --- a/fs/nfsd/nfs4xdr.c > +++ b/fs/nfsd/nfs4xdr.c > @@ -1628,6 +1628,7 @@ struct nfsd4_minorversion_ops { > static struct nfsd4_minorversion_ops nfsd4_minorversion[] = { > [0] = { nfsd4_dec_ops, ARRAY_SIZE(nfsd4_dec_ops) }, > [1] = { nfsd41_dec_ops, ARRAY_SIZE(nfsd41_dec_ops) }, > + [2] = { nfsd41_dec_ops, ARRAY_SIZE(nfsd41_dec_ops) }, > }; > > static __be32 > diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h > index 3090561..ac518e4 100644 > --- a/fs/nfsd/nfsd.h > +++ b/fs/nfsd/nfsd.h > @@ -24,7 +24,7 @@ > /* > * nfsd version > */ > -#define NFSD_SUPPORTED_MINOR_VERSION 1 > +#define NFSD_SUPPORTED_MINOR_VERSION 2 > /* > * Maximum blocksizes supported by daemon under various circumstances. > */ > -- > 1.8.1.4 >