Re: [PATCH 1/8] hfpmodem: Add codec watcher register

[Vinicius Costa Gomes <vinicius.gomes@openbossa.org>]

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

Hi Denis,

[snip]

> >+guint hfp_slc_codec_watch_register(struct hfp_slc_info *info,
> >+				hfp_slc_codec_watch_cb_t cb, void *user_data)
> >+{
> >+	struct codec_watch *watch = g_new0(struct codec_watch, 1);
> >+
> >+	watch->slc = info;
> >+	watch->cb = cb;
> >+	watch->user_data = user_data;
> >+
> >+	return g_at_chat_register(info->chat, "+BCS:", bcs_notify, FALSE,
> >+								watch, g_free);
> >+}
> 
> Why would you do this in the SLC ?  The SLC establishment only
> requires HF to send a BAC after the BRSF has been exchanged.  We do
> this successfully in brsf_cb.  I do not see why we can't monitor
> +BCS inside plugins/hfp_hf_bluez5.c?

The only point was to avoid having any AT logic inside the hfp_hf_bluez5
plugin. Will send an updated version with this logic inside hfp_hf_bluez5. It
does indeed make the code easier to follow.


Cheers,
-- 
Vinicius