From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 01/11] KVM: nVMX: Stats counters for nVMX Date: Thu, 11 Apr 2013 09:10:58 +0300 Message-ID: <20130411061058.GN17919@redhat.com> References: <1362931402-abelg@il.ibm.com> <20130310160355.885F5380134@moren.haifa.ibm.com> <20130408102727.GI17919@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dongxiao.xu@intel.com, jun.nakajima@intel.com, kvm@vger.kernel.org, nadav@harel.org.il, owasserm@redhat.com To: Abel Gordon Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39815 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752721Ab3DKGLK (ORCPT ); Thu, 11 Apr 2013 02:11:10 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Apr 10, 2013 at 10:08:56PM +0300, Abel Gordon wrote: > > > Gleb Natapov wrote on 08/04/2013 01:27:28 PM: > > > > stat counters are deprecated in favor of trace points. Adding kvmnested > > trace system is very welcome though. > > So, should I keep or remove this patch ? Remove. > If a kvmnested trace system is added then I'll add shadow-vmcs related > events Adding it is as simple as adding arch/x86/kvm/nestedtrace.h file similar to arch/x86/kvm/mmutrace.h. Doing #define TRACE_SYSTEM kvmnested there and adding trace events that you want to trace. The advantage is that you can provide additional information with each trace point. For example name and value of a field that was vmwread. -- Gleb.