From: Florian Westphal <fw@strlen.de>
To: Patrick McHardy <kaber@trash.net>
Cc: Florian Westphal <fw@strlen.de>,
netfilter-devel <netfilter-devel@vger.kernel.org>,
caiqian@redhat.com
Subject: Re: Fwd: Re: [BUG] Fatal exception in interrupt - nf_nat_cleanup_conntrack during IPv6 tests
Date: Thu, 11 Apr 2013 11:34:52 +0200 [thread overview]
Message-ID: <20130411093452.GA22909@breakpoint.cc> (raw)
In-Reply-To: <20130410145729.GC23626@macbook.localnet>
Patrick McHardy <kaber@trash.net> wrote:
> > > > Looks like it, nf_nat_ipv4 is listed as F- in the oops trace. (afaics,
> > > > "-" means "module going away").
> > >
> > > Yes, that seems like a real race condition. We probably could extend the
> > > nf_nat_lock sections to avoid this, but I wonder wether we should just kill
> > > those conntracks, the connections are not going to work after being
> > > "de-nated" anymore anyway.
> >
> > I like it, just killing them would make it a lot more simple.
> >
> > The clear-nat-extension-on-module-unload dance is getting out of hand,
> > and, as you point out, the connections are not going to work anyway...
>
> Yeah, lets just do that. Do you want to take care of this?
I can look into it, sure.
However, i missed one important point: non-NAT'd connections
have a null binding, and there doesn't seem to be a way to differentiate
between real vs. null binding.
Simply returning 1 for conntracks-with-nat-extension will zap every
connection.
next prev parent reply other threads:[~2013-04-11 9:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 9:04 Fwd: Re: [BUG] Fatal exception in interrupt - nf_nat_cleanup_conntrack during IPv6 tests Florian Westphal
2013-04-10 9:23 ` Patrick McHardy
2013-04-10 9:32 ` Florian Westphal
2013-04-10 9:41 ` Patrick McHardy
2013-04-10 14:56 ` Florian Westphal
2013-04-10 14:57 ` Patrick McHardy
2013-04-11 9:34 ` Florian Westphal [this message]
2013-04-11 10:40 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411093452.GA22909@breakpoint.cc \
--to=fw@strlen.de \
--cc=caiqian@redhat.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.