From mboxrd@z Thu Jan  1 00:00:00 1970
From: Egbert Eich <eich@freedesktop.org>
Subject: Re: [PATCH v3 6/7] drm/i915: Add bit field to record
 which pins have received HPD events (v2)
Date: Thu, 11 Apr 2013 15:34:54 +0200
Message-ID: <20130411133454.GB17947@debian>
References: <1365499470-28646-1-git-send-email-eich@freedesktop.org>
	<1365499470-28646-7-git-send-email-eich@freedesktop.org>
	<87zjx5nqx9.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from moutng.kundenserver.de (moutng.kundenserver.de
	[212.227.126.187])
	by gabe.freedesktop.org (Postfix) with ESMTP id 19402E661E
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 11 Apr 2013 06:35:01 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <87zjx5nqx9.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Egbert Eich <eich@suse.de>, Daniel Vetter <daniel.vetter@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Apr 11, 2013 at 04:21:54PM +0300, Jani Nikula wrote:
> >  		}
> > +		if (hpd_event_bits & (1 << intel_encoder->hpd_pin)) {
> > +			DRM_DEBUG_KMS("Connector %s (pin %i) received hotplug event.\n",
> > +				      drm_get_connector_name(connector), intel_encoder->hpd_pin);
> > +		}
> 
> I fear this may end up being a bit excessive debug printing.
> 

In a storm condition this is definitely true.
I still would like to keep this code in for debugging as I have 
some more ideas I would like to implement and test - however I
will wrap this code with #if 0 .. #endif so it can be enabled
easily.
Eventually I will remove it entirely.
Would this be ok with you?

Cheers,
	Egbert.