From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org,
Anmar Oueja <anmar.oueja@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH] MFD: ab8500: pass AB8500 IRQ to debugfs code by resource
Date: Thu, 11 Apr 2013 16:33:53 +0200 [thread overview]
Message-ID: <201304111633.54110.arnd@arndb.de> (raw)
In-Reply-To: <1365669779-14953-1-git-send-email-linus.walleij@stericsson.com>
On Thursday 11 April 2013, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> The AB8500 debug code which was merged in parallell with the
> multiplatform work incidentally introduced a new instance using
> the <mach/irqs.h> header which is now deleted, causing this
> build regression:
>
> drivers/mfd/ab8500-debugfs.c:95:23:
> fatal error: mach/irqs.h: No such file or directory
> compilation terminated.
> make[4]: *** [drivers/mfd/ab8500-debugfs.o] Error 1
>
> The code most certainly never worked with device tree either
> since that does not rely on this kind of hard-coded interrupt
> numbers.
>
> Fix the problem at the root by passing it as a named resource
> from the ab8500-core driver.
I think this won't work because the interrupts in ab8500_debug_resources
are now local numbers relative to the ab8500->domain irq_domain,
while IRQ_DB8500_AB8500 is an global interrupt number.
Arnd
next prev parent reply other threads:[~2013-04-11 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 8:42 [PATCH] MFD: ab8500: pass AB8500 IRQ to debugfs code by resource Linus Walleij
2013-04-11 14:33 ` Arnd Bergmann [this message]
2013-04-12 7:50 ` Linus Walleij
2013-04-12 8:08 ` Arnd Bergmann
2013-04-12 8:41 ` Linus Walleij
2013-04-12 10:48 ` Arnd Bergmann
2013-04-12 13:43 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304111633.54110.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=anmar.oueja@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.