From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: move debug output back to the right place Date: Thu, 11 Apr 2013 20:27:17 +0300 Message-ID: <20130411172717.GB4469@intel.com> References: <1365690550-5716-1-git-send-email-daniel.vetter@ffwll.ch> <1365691193-10212-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 05BEFE5C89 for ; Thu, 11 Apr 2013 10:27:25 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1365691193-10212-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Thu, Apr 11, 2013 at 04:39:53PM +0200, Daniel Vetter wrote: > When adding the pipe config computation step I've accidentally moved > this a bit away. Which momentarily confused me since the pipe config > step rejected some modesetting operations I expected and so left me > looking in vain for that debug output. > = > v2: Move the debug output into the right function to prevent this from > happening again. > = > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/intel_display.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/= intel_display.c > index 1b2c744..95f92ba 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -7629,6 +7629,9 @@ intel_modeset_affected_pipes(struct drm_crtc *crtc,= unsigned *modeset_pipes, > /* ... and mask these out. */ > *modeset_pipes &=3D ~(*disable_pipes); > *prepare_pipes &=3D ~(*disable_pipes); > + > + DRM_DEBUG_KMS("set mode pipe masks: modeset: %x, prepare: %x, disable: = %x\n", > + modeset_pipes, prepare_pipes, disable_pipes); *modeset_pipes, *prepare_pipes, *disable_pipes); > } > = > static bool intel_crtc_in_use(struct drm_crtc *crtc) > @@ -7859,9 +7862,6 @@ int intel_set_mode(struct drm_crtc *crtc, > } > } > = > - DRM_DEBUG_KMS("set mode pipe masks: modeset: %x, prepare: %x, disable: = %x\n", > - modeset_pipes, prepare_pipes, disable_pipes); > - > for_each_intel_crtc_masked(dev, disable_pipes, intel_crtc) > intel_crtc_disable(&intel_crtc->base); > = > -- = > 1.7.10.4 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC