From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60644)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UQMjp-0005D8-Fy
	for qemu-devel@nongnu.org; Thu, 11 Apr 2013 15:00:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UQMjn-0006b7-09
	for qemu-devel@nongnu.org; Thu, 11 Apr 2013 15:00:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42695)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1UQMjm-0006at-S8
	for qemu-devel@nongnu.org; Thu, 11 Apr 2013 15:00:46 -0400
Date: Thu, 11 Apr 2013 22:00:41 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130411190040.GF23301@redhat.com>
References: <1365696633-30727-1-git-send-email-pbonzini@redhat.com>
	<1365696633-30727-13-git-send-email-pbonzini@redhat.com>
	<CAFEAcA_zsnBrMm4JDwX1yQ3B-f7YjejqqryvhjDA5_NUfyzh4g@mail.gmail.com>
	<5166EE54.8040001@redhat.com>
	<CAFEAcA_d=H19cHGSaBkYJeR5Prymvq1wj=LG8yFrDKoFHML0BA@mail.gmail.com>
	<5166FE8C.5070000@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5166FE8C.5070000@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 12/12] hw: move memory API to hw/core
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

On Thu, Apr 11, 2013 at 08:18:52PM +0200, Paolo Bonzini wrote:
> Il 11/04/2013 19:14, Peter Maydell ha scritto:
> > On 11 April 2013 18:09, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >> Il 11/04/2013 18:28, Peter Maydell ha scritto:
> >>> On 11 April 2013 17:10, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >>>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >>> This doesn't look right. The MemoryRegion system isn't
> >>> hw-specific, it's a part of the basic QEMU emulation
> >>> system which provides functionality to hw/ and other
> >>> things (like cputlb.c).
> >>
> >> The accelerator- and target-independent parts of the basic emulation are
> >> already in hw/core (not much really, but consider that CPUs are device
> >> and depend on hw/core/qdev.c).  The memory API is simply the interface
> >> between the accelerators and hw/ (boards & device models).
> > 
> > Yes, so it should be provided in the place we put our accelerator
> > implementation (ie .): it is functionality and interface exposed
> > *to* the code in hw/, not functionality and interface provided
> > *by* hw/.
> 
> Ok, the historical practice was that qdev core was in hw/, and that's
> what I tried to follow.  It makes sense either way to me.
> 
> But then patch 11 also has to be dropped, otherwise it doesn't make
> sense.  Michael, what do you think?
> 
> Paolo

I agree.