From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 08/10] arm: kirkwood: convert QNAP TS219 to use DT for the PCIe interface
Date: Thu, 11 Apr 2013 21:33:49 +0200 [thread overview]
Message-ID: <20130411193349.GA5061@lunn.ch> (raw)
In-Reply-To: <1365632436-25367-9-git-send-email-thomas.petazzoni@free-electrons.com>
On Thu, Apr 11, 2013 at 12:20:34AM +0200, Thomas Petazzoni wrote:
> Now that the PCIe mvebu driver is usable on Kirkwood, use it instead
> of the legacy PCIe code, since it allows to describe the PCIe
> interfaces in the Device Tree.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> arch/arm/boot/dts/kirkwood-ts219.dtsi | 7 +++++++
> arch/arm/mach-kirkwood/board-ts219.c | 10 ----------
> 2 files changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> index 64ea27c..341e1d8 100644
> --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> @@ -74,5 +74,12 @@
> status = "okay";
> nr-ports = <2>;
> };
> + pcie-controller {
> + status = "okay";
> +
> + pcie at 1,0 {
> + status = "okay";
> + };
> + };
> };
> };
Hi Thomas
There is some DT weirdness going on here. With that you have above,
the .dtb file has both status="disabled" when i convert it back to dts
format.
In order to get it to work, i had to move this fragment into the
kirkwood-ts219-628[12].dtsi files.
Can some dtc guru comment if this is supposed to work with the
arrangement of includes we have?
Thanks
Andrew
next prev parent reply other threads:[~2013-04-11 19:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 22:20 [PATCHv2 00/10] Use the mvebu PCIe driver on Kirkwood Thomas Petazzoni
2013-04-10 22:20 ` [PATCHv2 01/10] pci: mvebu: enable driver usage " Thomas Petazzoni
2013-04-10 22:20 ` [PATCHv2 02/10] bus: mvebu: fix mistake in PCIe window target attribute for Kirkwood Thomas Petazzoni
2013-04-11 17:14 ` Jason Cooper
2013-04-10 22:20 ` [PATCHv2 03/10] arm: kirkwood: move PCIe window init to legacy driver Thomas Petazzoni
2013-04-10 22:20 ` [PATCHv2 04/10] arm: kirkwood: add SoC-level Device Tree data for PCIe interfaces Thomas Petazzoni
2013-04-13 10:30 ` Andrew Lunn
2013-04-13 14:04 ` Thomas Petazzoni
2013-04-13 19:04 ` Jason Cooper
2013-04-10 22:20 ` [PATCHv2 05/10] arm: kirkwood: convert Iomega Iconnect to use DT for the PCIe interface Thomas Petazzoni
2013-04-10 22:20 ` [PATCHv2 06/10] arm: kirkwood: convert MPL CEC4 " Thomas Petazzoni
2013-04-10 22:20 ` [PATCHv2 07/10] arm: kirkwood: convert ZyXEL NSA310 " Thomas Petazzoni
2013-04-10 22:20 ` [PATCHv2 08/10] arm: kirkwood: convert QNAP TS219 " Thomas Petazzoni
2013-04-11 0:33 ` Jason Cooper
2013-04-11 5:24 ` Andrew Lunn
2013-04-11 16:51 ` Jason Gunthorpe
2013-04-13 9:26 ` Andrew Lunn
2013-04-13 10:40 ` Thomas Petazzoni
2013-04-11 19:45 ` Andrew Lunn
2013-04-11 19:33 ` Andrew Lunn [this message]
2013-04-13 10:36 ` Andrew Lunn
2013-04-13 11:03 ` [PATCH] " Andrew Lunn
2013-04-10 22:20 ` [PATCHv2 09/10] arm: kirkwood: convert db-88f6281 to the Device Tree Thomas Petazzoni
2013-04-10 22:20 ` [PATCHv2 10/10] arm: kirkwood: update defconfig with PCIe driver and board updates Thomas Petazzoni
2013-04-13 13:14 ` [PATCHv2 00/10] Use the mvebu PCIe driver on Kirkwood Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411193349.GA5061@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.