From: Stephen Hemminger <stephen@networkplumber.org>
To: Mr Dash Four <mr.dash.four@googlemail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] iproute2: lib/utils.c bug fixes
Date: Thu, 11 Apr 2013 20:06:56 -0700 [thread overview]
Message-ID: <20130411200656.42dfb8bb@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <516771D5.3040607@googlemail.com>
On Fri, 12 Apr 2013 03:30:45 +0100
Mr Dash Four <mr.dash.four@googlemail.com> wrote:
> This patch fixes the following 3 bugs in get_u32/get_u64 functions:
>
> 1. On 32-bit systems, get_u32 could not detect an overflow.
> get_u32(&l, "4294967296", 10) always returned 4294967295
> (ULONG_MAX on 32-bit systems).
>
> 2. get_u64(&ll, "4294967295", 10) was returning an error where
> it shouldn't have (4294967295 is perfectly legitimate value for
> unsigned long long).
>
> 3. get_u64 couldn't detect an overflow errors (arg > ULLONG_MAX)
>
> Signed-off-by: Mr Dash Four <mr.dash.four@googlemail.com>
I don't demand Developer Certificate of Origin on iproute2 patches.
But if you are going to include it then you must use your real name,
no pseudonyms. See kernel/Documentation/SubmittingPatches.
next prev parent reply other threads:[~2013-04-12 3:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 2:30 [PATCH] iproute2: lib/utils.c bug fixes Mr Dash Four
2013-04-12 3:06 ` Stephen Hemminger [this message]
2013-04-12 13:49 ` Mr Dash Four
2013-04-12 14:25 ` Eric Dumazet
2013-04-12 14:38 ` Mr Dash Four
2013-04-12 15:09 ` Eric Dumazet
2013-04-12 15:25 ` Mr Dash Four
2013-04-12 15:45 ` Eric Dumazet
2013-04-12 16:15 ` Mr Dash Four
2013-04-12 16:21 ` Bjørn Mork
2013-04-12 16:02 ` Stephen Hemminger
2013-04-12 16:16 ` Mr Dash Four
2013-04-12 17:36 ` David Miller
2013-04-12 17:58 ` Mr Dash Four
2013-04-12 18:15 ` David Miller
2013-04-12 18:18 ` Hannes Frederic Sowa
2013-04-12 18:36 ` Mr Dash Four
2013-04-12 20:36 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130411200656.42dfb8bb@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=mr.dash.four@googlemail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.