From: andrew.murray@arm.com (Andrew Murray)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pci: pass a parent to pci_common_init()
Date: Fri, 12 Apr 2013 14:48:11 +0100 [thread overview]
Message-ID: <20130412134811.GA26188@arm.com> (raw)
In-Reply-To: <201304121501.48866.arnd@arndb.de>
On Fri, Apr 12, 2013 at 02:01:48PM +0100, Arnd Bergmann wrote:
> On Friday 12 April 2013, Andrew Murray wrote:
> > I would also be happy with this. Though alternatively could you
> > not just add a struct device to hw_pci? Then change pcibios_init_hw
> > to use hw->device instead of NULL?
> >
>
> I think struct hw_pci is meant to be statically defined, so that would
> not work if you need the same hw_pci for two host bridge devices.
>
> Arnd
>
Yes, though the new PCIe host/bridge drivers with DT support all seem to call
pci_common_init at probe with a non-statically defined hw_pci with the
nr_controllers always set to 1 (meaning that pci_common_init can be called
multiple times). Also hw_pci now has a field for private_data anyway which
breaks this assumption...
Is there an argument for removing hw_pci or at least .nr_controllers and call
pci_common_init multiple times (as is potential current use case for DT PCI
drivers)?
Andrew Murray
next prev parent reply other threads:[~2013-04-12 13:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1365719096-11639-1-git-send-email-linus.walleij@linaro.org>
2013-04-12 11:26 ` [PATCH] ARM: pci: pass a parent to pci_common_init() Arnd Bergmann
2013-04-12 12:05 ` Andrew Murray
2013-04-12 13:01 ` Arnd Bergmann
2013-04-12 13:48 ` Andrew Murray [this message]
2013-04-19 13:19 ` Russell King - ARM Linux
2013-04-19 13:06 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130412134811.GA26188@arm.com \
--to=andrew.murray@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.