From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQzV6-0007j3-72 for qemu-devel@nongnu.org; Sat, 13 Apr 2013 08:24:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQzV4-0005Tw-VV for qemu-devel@nongnu.org; Sat, 13 Apr 2013 08:24:12 -0400 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:40332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQzV4-0005Tk-PO for qemu-devel@nongnu.org; Sat, 13 Apr 2013 08:24:10 -0400 Date: Sat, 13 Apr 2013 14:24:07 +0200 From: Aurelien Jarno Message-ID: <20130413122407.GQ5000@ohm.aurel32.net> References: <1365116186-19382-1-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1365116186-19382-1-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH v4 00/33] Modernize tcg/ppc64 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: av1474@comtv.ru, qemu-devel@nongnu.org On Thu, Apr 04, 2013 at 05:55:53PM -0500, Richard Henderson wrote: > Changes v3-v4: > > There were two problems, both related to the setcond opcode: > > * The first was pre-existing: the current code gets 32-bit NE wrong, > failing to ignore the high 32-bits of the register. This problem > caused the rest of the patch set to be non-bisectable -- any non- > trivial change to code generation of the 32-bit opcodes tended to > expose this. > > * The second was in the setcond rewrite, in that my logic was wrong > for the signed comparisons. > > In the process of tracking all of this down, I split up the setcond > changes into three parts, and dropped the carry-bit optimization part > entirely. It may still be an improvement for the unsigned comparisons, > but since I have switched to MFOCRF it'll be harder to show a speedup > in practice. > > Finally, one extra patch to avoid a regression in code generation when > insertting zero via deposit. > > Tested with arm-test, sparc-test, and i386-softmmu nbench. > > Tree updated at > > git://github.com/rth7680/qemu.git tcg-ppc64 > Oops it looks like I reviewed the V3, while testing the version in your git tree, so the V4. Therefore my comments about the tests I have done apply to this version, and I'll review the remaining patches of this version over the week-end. Tested-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net