All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Rees <rees@umich.edu>
To: Steve Dickson <steved@redhat.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	Simo Sorce <simo@redhat.com>
Subject: Re: [PATCH] Avoid DNS reverse resolution for server names
Date: Sat, 13 Apr 2013 11:08:48 -0400	[thread overview]
Message-ID: <20130413150848.GA780@umich.edu> (raw)
In-Reply-To: <1365862193-21986-2-git-send-email-steved@redhat.com>

I find this very confusing. You've got a global named "avoid_dns", which you
turn off if you have the "-D" option. And if it's set, you do a dns lookup:

  +	if (avoid_dns) {
...
  +			do_dns_lookup = 1; /* IPv4 */

At the very least I would call it something like "do_ptr_lookup" and invert
its meaning.

      reply	other threads:[~2013-04-13 15:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13 14:09 [PATCH] Alternative patchset to avoid PTR lookups (take 2) Steve Dickson
2013-04-13 14:09 ` [PATCH] Avoid DNS reverse resolution for server names Steve Dickson
2013-04-13 15:08   ` Jim Rees [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130413150848.GA780@umich.edu \
    --to=rees@umich.edu \
    --cc=linux-nfs@vger.kernel.org \
    --cc=simo@redhat.com \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.