From: Dave Reisner <d@falconindy.com>
To: Sami Kerola <kerolasa@iki.fi>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 05/33] bash-completion: prefer bash 3.x 'here string' syntax
Date: Sat, 13 Apr 2013 17:59:13 -0400 [thread overview]
Message-ID: <20130413215913.GF11968@rampage> (raw)
In-Reply-To: <1365882901-11429-6-git-send-email-kerolasa@iki.fi>
On Sat, Apr 13, 2013 at 08:54:33PM +0100, Sami Kerola wrote:
> The '< <' syntax is bash 2.x trick, and <<< does the same job when bash
> 3.x is in use. For some unknown reason my bash 4.2.45(2)-release became
> allergic to old syntax today(?).
I don't follow this. The syntax is <(commands), which is a process
substitution. It creates a temporary file descriptor which can be
redirected via <. It still very much works, and I don't expect this to
break any time soon. It's likely more memory efficient since there's no
need to expand the output in place -- it can just be read off of the
file descriptor.
I think you should figure out what's wrong with your shell instead of
doing this.
> Reference: http://linuxshellaccount.blogspot.co.uk/2008/08/using-bash-to-feed-command-output-to.html
> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
> ---
> bash-completion/addpart | 2 +-
> bash-completion/blkdiscard | 2 +-
> bash-completion/blkid | 2 +-
> bash-completion/blockdev | 2 +-
> bash-completion/delpart | 2 +-
> bash-completion/fdisk | 4 ++--
> bash-completion/findmnt | 2 +-
> bash-completion/fsck | 2 +-
> bash-completion/fsck.minix | 2 +-
> bash-completion/lsblk | 2 +-
> bash-completion/mkfs | 2 +-
> bash-completion/mkfs.bfs | 2 +-
> bash-completion/mkfs.minix | 2 +-
> bash-completion/partx | 2 +-
> bash-completion/resizepart | 2 +-
> bash-completion/sfdisk | 2 +-
> bash-completion/wipefs | 2 +-
> 17 files changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/bash-completion/addpart b/bash-completion/addpart
> index 2b1e6bb..3b4e603 100644
> --- a/bash-completion/addpart
> +++ b/bash-completion/addpart
> @@ -6,7 +6,7 @@ _addpart_module()
> case $COMP_CWORD in
> 1)
> local DEVS=''
> - while read dev; do DEVS+="$dev " ; done < <(lsblk -pnro name)
> + while read dev; do DEVS+="$dev " ; done <<<"$(lsblk -pnro name)"
> OPTS="--help --version $DEVS"
> COMPREPLY=( $(compgen -W "${OPTS[*]}" -- $cur) )
> ;;
> diff --git a/bash-completion/blkdiscard b/bash-completion/blkdiscard
> index 310cdfb..9e2e262 100644
> --- a/bash-completion/blkdiscard
> +++ b/bash-completion/blkdiscard
> @@ -21,7 +21,7 @@ _blkdiscard_module()
> ;;
> esac
> local DEVS
> - DEVS=''; while read dev; do DEVS+="$dev " ; done < <(lsblk -pnro name)
> + DEVS=''; while read dev; do DEVS+="$dev " ; done <<<"$(lsblk -pnro name)"
> COMPREPLY=( $(compgen -W "$DEVS" -- $cur) )
> return 0
> }
> diff --git a/bash-completion/blkid b/bash-completion/blkid
> index b439328..de8b8ce 100644
> --- a/bash-completion/blkid
> +++ b/bash-completion/blkid
> @@ -60,7 +60,7 @@ _blkid_module()
> local DEV TYPE DEVICES=''
> while read DEV TYPE; do
> [ $TYPE = 'part' ] && DEVICES+="$DEV "
> - done < <(lsblk -pnro name,type)
> + done <<<"$(lsblk -pnro name,type)"
> COMPREPLY=( $(compgen -W "$DEVICES" -- $cur) )
> return 0
> }
> diff --git a/bash-completion/blockdev b/bash-completion/blockdev
> index ce986cb..4c86cda 100644
> --- a/bash-completion/blockdev
> +++ b/bash-completion/blockdev
> @@ -4,7 +4,7 @@ _blockdev_module()
> COMPREPLY=()
> cur="${COMP_WORDS[COMP_CWORD]}"
> prev="${COMP_WORDS[COMP_CWORD-1]}"
> - while read dev; do DEVS+="$dev " ; done < <(lsblk -pnro name)
> + while read dev; do DEVS+="$dev " ; done <<<"$(lsblk -pnro name)"
> OPTS="-h -V -q
> --report
> --getsz
> diff --git a/bash-completion/delpart b/bash-completion/delpart
> index a4b20c8..6fa7006 100644
> --- a/bash-completion/delpart
> +++ b/bash-completion/delpart
> @@ -14,7 +14,7 @@ _delpart_module()
> local DEV TYPE DEVICES=''
> while read DEV TYPE; do
> [ $TYPE = 'disk' ] && DEVICES+="$DEV "
> - done < <(lsblk -pnro name,type)
> + done <<<"$(lsblk -pnro name,type)"
> OPTS="--help --version $DEVICES"
> COMPREPLY=( $(compgen -W "${OPTS[*]}" -- $cur) )
> ;;
> diff --git a/bash-completion/fdisk b/bash-completion/fdisk
> index b800f8d..4a59070 100644
> --- a/bash-completion/fdisk
> +++ b/bash-completion/fdisk
> @@ -9,7 +9,7 @@ _fdisk_module()
> local DEV TYPE DEVICES=''
> while read DEV TYPE; do
> [ $TYPE = 'part' ] && DEVICES+="$DEV "
> - done < <(lsblk -pnro name,type)
> + done <<<"$(lsblk -pnro name,type)"
> COMPREPLY=( $(compgen -W "$DEVICES" -- $cur) )
> return 0
> ;;
> @@ -43,7 +43,7 @@ _fdisk_module()
> local DEV TYPE DEVICES=''
> while read DEV TYPE; do
> [ $TYPE = 'disk' ] && DEVICES+="$DEV "
> - done < <(lsblk -pnro name,type)
> + done <<<"$(lsblk -pnro name,type)"
> COMPREPLY=( $(compgen -W "$DEVICES" -- $cur) )
> return 0
> }
> diff --git a/bash-completion/findmnt b/bash-completion/findmnt
> index 9386d8f..4cb0be8 100644
> --- a/bash-completion/findmnt
> +++ b/bash-completion/findmnt
> @@ -37,7 +37,7 @@ _findmnt_module()
> for I in ${TMP_ARR[@]}; do
> MNT_OPTS[$I]='1'
> done
> - done < <(findmnt -rno OPTIONS)
> + done <<<"$(findmnt -rno OPTIONS)"
> COMPREPLY=( $(compgen -W "${!MNT_OPTS[@]}" -- $cur) )
> return 0
> ;;
> diff --git a/bash-completion/fsck b/bash-completion/fsck
> index 04899a0..448b6b7 100644
> --- a/bash-completion/fsck
> +++ b/bash-completion/fsck
> @@ -32,7 +32,7 @@ _fsck_module()
> return 0
> ;;
> esac
> - while read dev; do DEVS+="$dev " ; done < <(lsblk -pnro name)
> + while read dev; do DEVS+="$dev " ; done <<<"$(lsblk -pnro name)"
> COMPREPLY=( $(compgen -W "$DEVS" -- $cur) )
> return 0
> }
> diff --git a/bash-completion/fsck.minix b/bash-completion/fsck.minix
> index 1ec9a78..b9ff739 100644
> --- a/bash-completion/fsck.minix
> +++ b/bash-completion/fsck.minix
> @@ -9,7 +9,7 @@ _fsck.minix_module()
> return 0
> ;;
> esac
> - while read dev; do DEVS+="$dev " ; done < <(lsblk -pnro name)
> + while read dev; do DEVS+="$dev " ; done <<<"$(lsblk -pnro name)"
> OPTS="-l -a -r -v -s -m -f --version"
> COMPREPLY=( $(compgen -W "${OPTS[*]} $DEVS" -- $cur) )
> return 0
> diff --git a/bash-completion/lsblk b/bash-completion/lsblk
> index 07e9368..2beb8a5 100644
> --- a/bash-completion/lsblk
> +++ b/bash-completion/lsblk
> @@ -61,7 +61,7 @@ _lsblk_module()
> ;;
> esac
> local DEVS
> - DEVS=''; while read dev; do DEVS+="$dev " ; done < <(lsblk -pnro name)
> + DEVS=''; while read dev; do DEVS+="$dev " ; done <<<"$(lsblk -pnro name)"
> COMPREPLY=( $(compgen -W "$DEVS" -- $cur) )
> return 0
> }
> diff --git a/bash-completion/mkfs b/bash-completion/mkfs
> index 4e6e175..daa9ea5 100644
> --- a/bash-completion/mkfs
> +++ b/bash-completion/mkfs
> @@ -21,7 +21,7 @@ _mkfs_module()
> return 0
> ;;
> esac
> - while read dev; do DEVS+="$dev " ; done < <(lsblk -pnro name)
> + while read dev; do DEVS+="$dev " ; done <<<"$(lsblk -pnro name)"
> COMPREPLY=( $(compgen -W "$DEVS /path/to/file" -- $cur) )
> return 0
> }
> diff --git a/bash-completion/mkfs.bfs b/bash-completion/mkfs.bfs
> index 8adbc60..4f56403 100644
> --- a/bash-completion/mkfs.bfs
> +++ b/bash-completion/mkfs.bfs
> @@ -24,7 +24,7 @@ _bfs_module()
> return 0
> ;;
> esac
> - while read dev; do DEVS+="$dev " ; done < <(lsblk -pnro name)
> + while read dev; do DEVS+="$dev " ; done <<<"$(lsblk -pnro name)"
> COMPREPLY=( $(compgen -W "$DEVS /path/to/file" -- $cur) )
> return 0
> }
> diff --git a/bash-completion/mkfs.minix b/bash-completion/mkfs.minix
> index 78c986f..e7b60a3 100644
> --- a/bash-completion/mkfs.minix
> +++ b/bash-completion/mkfs.minix
> @@ -29,7 +29,7 @@ _mkfs.minix_module()
> ;;
> esac
> local DEVS
> - while read dev; do DEVS+="$dev " ; done < <(lsblk -pnro name)
> + while read dev; do DEVS+="$dev " ; done <<<"$(lsblk -pnro name)"
> COMPREPLY=( $(compgen -W "$DEVS" -- $cur) )
> return 0
> }
> diff --git a/bash-completion/partx b/bash-completion/partx
> index 7b08fa8..9b382fd 100644
> --- a/bash-completion/partx
> +++ b/bash-completion/partx
> @@ -34,7 +34,7 @@ _partx_module()
> local DEV TYPE DEVICES=''
> while read DEV TYPE; do
> [ $TYPE = 'disk' ] && DEVICES+="$DEV "
> - done < <(lsblk -pnro name,type)
> + done <<<"$(lsblk -pnro name,type)"
> COMPREPLY=( $(compgen -W "$DEVICES" -- $cur) )
> return 0
> }
> diff --git a/bash-completion/resizepart b/bash-completion/resizepart
> index c78af15..08a95f0 100644
> --- a/bash-completion/resizepart
> +++ b/bash-completion/resizepart
> @@ -14,7 +14,7 @@ _resizepart_module()
> local DEV TYPE DEVICES=''
> while read DEV TYPE; do
> [ $TYPE = 'disk' ] && DEVICES+="$DEV "
> - done < <(lsblk -pnro name,type)
> + done <<<"$(lsblk -pnro name,type)"
> OPTS="--help --version $DEVICES"
> COMPREPLY=( $(compgen -W "${OPTS[*]}" -- $cur) )
> ;;
> diff --git a/bash-completion/sfdisk b/bash-completion/sfdisk
> index 0226b04..d39e2ba 100644
> --- a/bash-completion/sfdisk
> +++ b/bash-completion/sfdisk
> @@ -75,7 +75,7 @@ _sfdisk_module()
> local DEV TYPE DEVICES=''
> while read DEV TYPE; do
> [ $TYPE = 'disk' ] && DEVICES+="$DEV "
> - done < <(lsblk -pnro name,type)
> + done <<<"$(lsblk -pnro name,type)"
> COMPREPLY=( $(compgen -W "$DEVICES" -- $cur) )
> return 0
> }
> diff --git a/bash-completion/wipefs b/bash-completion/wipefs
> index e0e3286..f0a3ba6 100644
> --- a/bash-completion/wipefs
> +++ b/bash-completion/wipefs
> @@ -27,7 +27,7 @@ _wipefs_module()
> ;;
> esac
> local DEVS
> - DEVS=''; while read dev; do DEVS+="$dev " ; done < <(lsblk -pnro name)
> + DEVS=''; while read dev; do DEVS+="$dev " ; done <<<"$(lsblk -pnro name)"
> COMPREPLY=( $(compgen -W "$DEVS" -- $cur) )
> return 0
> }
> --
> 1.8.2.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe util-linux" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-04-13 21:59 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 19:54 [PATCH 00/33] pull: bash completions, help screens, and file writing Sami Kerola
2013-04-13 19:54 ` [PATCH 01/33] bash-completion: add mount and umount Sami Kerola
2013-04-13 19:54 ` [PATCH 02/33] blkid, hwclock, ldattach: use program_invocation_short_name Sami Kerola
2013-04-13 19:54 ` [PATCH 03/33] utmpdump: add option to write to a file Sami Kerola
2013-04-13 19:54 ` [PATCH 04/33] cfdisk: add long options to the command Sami Kerola
2013-04-26 11:30 ` Karel Zak
2013-04-13 19:54 ` [PATCH 05/33] bash-completion: prefer bash 3.x 'here string' syntax Sami Kerola
2013-04-13 21:59 ` Dave Reisner [this message]
2013-04-26 11:38 ` Karel Zak
2013-04-26 12:29 ` Sami Kerola
2013-04-13 19:54 ` [PATCH 06/33] setpriv: allow login and group name option arguments Sami Kerola
2013-04-13 19:54 ` [PATCH 07/33] build-sys: add --disable-setterm to ./configure Sami Kerola
2013-04-26 11:53 ` Karel Zak
2013-04-13 19:54 ` [PATCH 08/33] hexdump: add long options to the command Sami Kerola
2013-04-13 19:54 ` [PATCH 09/33] setsid: exit when control terminal cannot be set Sami Kerola
2013-04-13 19:54 ` [PATCH 10/33] cfdisk: check writing to a file was successful Sami Kerola
2013-04-13 19:54 ` [PATCH 11/33] setpriv: " Sami Kerola
2013-04-13 19:54 ` [PATCH 12/33] agetty: " Sami Kerola
2013-04-13 19:54 ` [PATCH 13/33] pg: " Sami Kerola
2013-04-13 19:54 ` [PATCH 14/33] libblkid: " Sami Kerola
2013-04-13 19:54 ` [PATCH 15/33] libmount: " Sami Kerola
2013-04-13 19:54 ` [PATCH 16/33] include: add close_fd() for noticing write errors before close() Sami Kerola
2013-04-13 19:54 ` [PATCH 17/33] fdformat: check writing to a file descriptor was successful Sami Kerola
2013-04-13 19:54 ` [PATCH 18/33] partx: " Sami Kerola
2013-04-13 19:54 ` [PATCH 19/33] resizepart: " Sami Kerola
2013-04-13 19:54 ` [PATCH 20/33] cfdisk: " Sami Kerola
2013-04-13 19:54 ` [PATCH 21/33] sfdisk: " Sami Kerola
2013-04-13 19:54 ` [PATCH 22/33] wdctl: " Sami Kerola
2013-04-13 19:54 ` [PATCH 23/33] fsck.cramfs: " Sami Kerola
2013-04-13 19:54 ` [PATCH 24/33] fsck.minix: " Sami Kerola
2013-04-13 19:54 ` [PATCH 25/33] mkfs.bfs: " Sami Kerola
2013-04-13 19:54 ` [PATCH 26/33] mkfs.cramfs: unify write check to a file descriptor Sami Kerola
2013-04-13 19:54 ` [PATCH 27/33] mkfs.minix: check writing to a file descriptor was successful Sami Kerola
2013-04-13 19:54 ` [PATCH 28/33] mkswap: unify write check to a file descriptor Sami Kerola
2013-04-13 19:54 ` [PATCH 29/33] swaplabel: check writing to a file descriptor was successful Sami Kerola
2013-04-13 19:54 ` [PATCH 30/33] fallocate: " Sami Kerola
2013-04-13 19:54 ` [PATCH 31/33] setpriv: " Sami Kerola
2013-04-13 19:55 ` [PATCH 32/33] swapon: " Sami Kerola
2013-04-13 19:55 ` [PATCH 33/33] wall: " Sami Kerola
2013-04-17 13:31 ` [PATCH 00/33] pull: bash completions, help screens, and file writing Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130413215913.GF11968@rampage \
--to=d@falconindy.com \
--cc=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.