From: Stephen Hemminger <stephen@networkplumber.org>
To: Mike Rapoport <mike.rapoport@ravellosystems.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next] vxlan: use htonl when snooping for loopback address
Date: Sun, 14 Apr 2013 09:57:39 -0700 [thread overview]
Message-ID: <20130414095739.5ddfbe0a@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1365931299-26240-1-git-send-email-mike.rapoport@ravellosystems.com>
On Sun, 14 Apr 2013 12:21:39 +0300
Mike Rapoport <mike.rapoport@ravellosystems.com> wrote:
> Currently "bridge fdb show dev vxlan0" lists loopback address as
> "1.0.0.127". Using htonl(INADDR_LOOPBACK) rather than passing it
> directly to vxlan_snoop fixes the problem.
>
> Signed-off-by: Mike Rapoport <mike.rapoport@ravellosystems.com>
> ---
> drivers/net/vxlan.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index ee02ecd..725aba3 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -925,7 +925,8 @@ static void vxlan_encap_bypass(struct sk_buff *skb, struct vxlan_dev *src_vxlan,
> __skb_pull(skb, skb_network_offset(skb));
>
> if (dst_vxlan->flags & VXLAN_F_LEARN)
> - vxlan_snoop(skb->dev, INADDR_LOOPBACK, eth_hdr(skb)->h_source);
> + vxlan_snoop(skb->dev, htonl(INADDR_LOOPBACK),
> + eth_hdr(skb)->h_source);
>
> u64_stats_update_begin(&tx_stats->syncp);
> tx_stats->tx_packets++;
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2013-04-14 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-14 9:21 [PATCH net-next] vxlan: use htonl when snooping for loopback address Mike Rapoport
2013-04-14 15:07 ` Cong Wang
2013-04-14 16:57 ` Stephen Hemminger [this message]
2013-04-14 19:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130414095739.5ddfbe0a@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=mike.rapoport@ravellosystems.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.