From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-s390@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ?
Date: Mon, 15 Apr 2013 07:48:14 +0200 [thread overview]
Message-ID: <20130415054814.GA4207@osiris> (raw)
In-Reply-To: <1365919574.1878.13.camel@joe-AO722>
On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote:
> Hello Heiko.
>
> Commit ea81531d ("s390/uaccess: fix page table walk")
> added this code. It looks like it should have break;
> for each case.
Hi Joe,
no, the fallthrough is on purpose for each case statement.
> static unsigned long follow_table(struct mm_struct *mm,
> unsigned long address, int write)
> {
> unsigned long *table = (unsigned long *)__pa(mm->pgd);
>
> switch (mm->context.asce_bits & _ASCE_TYPE_MASK) {
> case _ASCE_TYPE_REGION1:
> table = table + ((address >> 53) & 0x7ff);
> if (unlikely(*table & _REGION_ENTRY_INV))
> return -0x39UL;
> table = (unsigned long *)(*table & _REGION_ENTRY_ORIGIN);
> case _ASCE_TYPE_REGION2:
next prev parent reply other threads:[~2013-04-15 5:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-14 6:06 arch/s390/lib/uaccess_pt.c: Missing breaks: ? Joe Perches
2013-04-15 5:48 ` Heiko Carstens [this message]
2013-04-15 5:53 ` Joe Perches
2013-04-15 5:58 ` Heiko Carstens
2013-04-15 6:15 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130415054814.GA4207@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.